Closed Bug 1228266 Opened 4 years ago Closed 3 years ago

[Presentation WebAPI] Rename TCPPresentationServer to PresentationControlService

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
blocking-b2g 2.6+
Tracking Status
firefox49 --- fixed
b2g-v2.6 --- fixed

People

(Reporter: junior, Assigned: schien)

References

Details

(Whiteboard: [ETA 5/26])

Attachments

(2 files, 1 obsolete file)

The name is not intuitive and hard to remember. We should find a good name.
How about "PresentationControlService" since this class implements both client and server of control protocol?
(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #1)
> How about "PresentationControlService" since this class implements both
> client and server of control protocol?

This is better than the original name.
summary of the changes:
1. rename TCPPresentationServer.js to PresentationControlService.js
2. rename nsITCPPresentationServer to nsIPresentationControlServer
3. rename nsITCPPresentationServerListener to nsIPresentationControlServerListener (not 'Service' because those events are for server side only)
4. rename startService to startServer
5. change TCP_PRESENTATION_SERVER_CONTRACT_ID to PRESENTATION_CONTROL_SERVICE_CONTRACT_ID, and also change the string to "@mozilla.org/presentation/control-service;1"
6. rename variable names like 'presentationServer' to 'presentationService'
7. update log message and comments
Assignee: nobody → schien
Summary: [Presentation WebAPI] Rename |TCPPresentationServer.js| → [Presentation WebAPI] Rename TCPPresentationServer to PresentationControlService
We need to rename it on both TV2.6 branch and m-c to reduce future uplift effort.
blocking-b2g: --- → 2.6?
Whiteboard: [ETA 5/26]
Comment on attachment 8754687 [details]
MozReview Request: Bug 1228266 - rename TCPPresentationServer to PresentationControlService. r=junior.

https://reviewboard.mozilla.org/r/54176/#review50886

Looks good to me
Attachment #8754687 - Flags: review?(juhsu) → review+
Comment on attachment 8754687 [details]
MozReview Request: Bug 1228266 - rename TCPPresentationServer to PresentationControlService. r=junior.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54176/diff/1-2/
(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #7)
> Comment on attachment 8754687 [details]
> MozReview Request: Bug 1228266 - rename TCPPresentationServer to
> PresentationControlService. r=junior.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/54176/diff/1-2/

update for missing package-manifest.in changes.
blocking-b2g: 2.6? → 2.6+
https://hg.mozilla.org/mozilla-central/rev/c4d79ead2131
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Comment on attachment 8754687 [details]
MozReview Request: Bug 1228266 - rename TCPPresentationServer to PresentationControlService. r=junior.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Presentation API
User impact if declined: n/a
Testing completed: with automation test
Risk to taking this patch (and alternatives if risky): no risk
String or UUID changes made by this patch: n/a
Attachment #8754687 - Flags: approval-mozilla-b2g48?
Blocks: 1275351
See Also: → 1275351
Comment on attachment 8754687 [details]
MozReview Request: Bug 1228266 - rename TCPPresentationServer to PresentationControlService. r=junior.

Approve for TV 2.6
Attachment #8754687 - Flags: approval-mozilla-b2g48? → approval-mozilla-b2g48+
Attached file rebase for tv 2.6 (obsolete) —
tv 2.6 patch is ready.
Flags: needinfo?(xeonchen)
Attached file rebase for tv 2.6, v2
Attachment #8757852 - Attachment is obsolete: true
Flags: needinfo?(xeonchen)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.