Closed Bug 1228278 Opened 9 years ago Closed 8 years ago

TEST-UNEXPECTED-ERROR | test_about_private_browsing.py TestAboutPrivateBrowsing.testCheckAboutPrivateBrowsing | TimeoutException: TimeoutException: Timed out after 5.0 seconds

Categories

(Testing :: Firefox UI Tests, defect)

Product:
Testing
Component:
Firefox UI Tests
Version:
45 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox43 fixed, firefox44 fixed, firefox45 fixed, firefox46 fixed, firefox-esr38 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla46
Tracking Flags:
Tracking Status
firefox43 --- fixed
firefox44 --- fixed
firefox45 --- fixed
firefox46 --- fixed
firefox-esr38 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

Github PR (non-packaged mode - all branches)
52 bytes, text/x-github-pull-request
impossibus
: review+
Details | Review 
Maybe the window doesn't open? It's a new failure we see starting yesterday only for the Russian locale on Windows.

Traceback (most recent call last):
  File "c:\jenkins\workspace\mozilla-aurora_functional\tests_venv\lib\site-packages\marionette\marionette_test.py", line 344, in run
    testMethod()
  File "c:\jenkins\workspace\mozilla-aurora_functional\tests_venv\lib\site-packages\marionette\marionette_test.py", line 108, in wrapper
    return target(self, *args, **kwargs)
  File "c:\jenkins\workspace\mozilla-aurora_functional\tests_venv\Lib\site-packages\firefox_ui_tests\functional\private_browsing\test_about_private_browsing.py", line 42, in testCheckAboutPrivateBrowsing
    expected_window_class=BrowserWindow)
  File "c:\jenkins\workspace\mozilla-aurora_functional\tests_venv\lib\site-packages\firefox_puppeteer\ui\windows.py", line 349, in open_window
    Wait(self.marionette).until(window_opened)
  File "c:\jenkins\workspace\mozilla-aurora_functional\tests_venv\lib\site-packages\marionette_driver\wait.py", line 143, in until
    cause=last_exc)
I was able to reproduce it locally. The problem here seems to be that a locationbar test keeps the edit bookmark dialog open and doesn't close it. So a shortcut in the following private browsing test fails. I will check why exactly the dialog does not close.
So several issues here.

1. We try to wait for the done button to be visible. As written this does not work because we do not call is_displayed but evaluate the method inside until:

https://github.com/mozilla/firefox-ui-tests/blob/mozilla-central/firefox_ui_tests/functional/locationbar/test_suggest_bookmarks.py#L59

2. We should not use `is_displayed()` because it is broken in chrome scope. So the DOM element's attribute has to be checked directly.

3. We do not force close the editbookmarkpanel in teardown. So if the test fails before closing the panel it will stay open and cause bustage in following tests.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attached patch possible patch (obsolete) — — Splinter Review 
Possible patch to fix this problem. I'm not sure why only localized builds are affected and en-US doesn't show it. But it works and fixes the problem.

I will create a PR once the packages branch has been merged to mozilla-central.
Depends on: 1232967
Lets not make it dependent because it would take some days. Instead lets get it fixed immediately.
status-firefox43: --- → affected
status-firefox46: --- → affected
status-firefox-esr38: --- → affected
No longer depends on: 1232967
This patch fixes the issue for all branches. We need a separate patch for the python_packages branch and hg.mo.
Attachment #8704600 - Attachment is obsolete: true
Attachment #8704606 - Flags: review?(mjzffr)
Blocks: 1237322
Comment on attachment 8704606 [details] [review]
Github PR (non-packaged mode - all branches)

r+ assuming the Travis failure is unrelated.
Attachment #8704606 - Flags: review?(mjzffr) → review+
Product: Mozilla QA → Testing
I rebased the integration branch for the latest changes on mozilla-central, and had to fix another bug in the new code which was thankfully identified by Travis. Now everything is green.

Merged the PR into mozilla-central as:
https://github.com/mozilla/firefox-ui-tests/commit/4b59f7b6505f8934a41d034eb4e57a65fdbb2551

I also merged it to the python_packages branch.

I will do the backports once mozilla-central on hg.mo is completely done.
status-firefox46: affected → fixed
Target Milestone: --- → mozilla46
For now I backported this only to Aurora given that this is the first branch where we are using other locales than en-US and ru was always failing here. Lets see if that has been fixed.

https://github.com/mozilla/firefox-ui-tests/commit/15ef277152440f33a1b4d56d721eebbccfd5a575 (aurora)
status-firefox45: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: