12283 - [DOGFOOD] Bookmarks deselection slow.

Status: VERIFIED DUPLICATE of bug 12598

(SeaMonkey :: General, defect, P3)

Description

[David Hyatt]

For some reason that I suspect has to do with the bookmarks JS (and not with any
C++ code), the deselection of items in the bookmarks tree is very very slow.  To
test, select multiple items rapidly using CTRL-click to add each bookmark in.
You'll see that this happens quickly.  Get 5 or 6 items selected and then click
on an unselected item.

Watch as it takes nearly a full second for the 5 or 6 selected items to be
deselected before the new item gets selected.

I only see this in the bookmarks tree, so I suspect you're doing something weird
in the JS.

Comment 1

[Chris Waterson]

This is because of the way selection is currently implemented in the tree
control: it walks the entire content model to discover what nodes are/aren't
selected. Reassigning to hyatt: he has a scheduled task (AFAIK) to implement
this.

Comment 2

[Chris Waterson]

Well hmmph. I guess hyatt fixed all that. I'll take a look...

Comment 3

[David Hyatt]

No, it isn't.  I'm using the re-written fast selection and this is still
happening.

Comment 4

[Robert John Churchill]

For what its worth, the bookmarks tree only has a ondblclick() handler now.
There is no onclick() handler ['cept on columns]... so its probably not JS.

Comment 5

[David Hyatt]

Yeah, something weird is going on.  For some reason, this tree is much slower
than other trees at selection.  I assumed it was JS, but now I don't think it
is.

Comment 6

[Chris Waterson]

Hey Hyatt, is this fixed with your snazzy new tree widget stuff? If not, I
think you figured out that it was a dumb style rule we were using?

Comment 7

[David Hyatt]

*** This bug has been marked as a duplicate of 12598 ***

Comment 8

[leger]

marking Verified as a dup.