Unintended regular expression in CrashReporter.java

RESOLVED FIXED in Firefox 45

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

({coverity})

unspecified
Firefox 45
coverity
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

(Whiteboard: [CID 119567])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Created attachment 8692504 [details] [diff] [review]
regexp.diff

CID 119567 (#1 of 1): Unintended regular expression (REGEX_CONFUSION)regex_expected: The . character(s) in the pattern ".dmp" can match any character, because calls to replaceAll treat the pattern as a regular expression, which might be unexpected.
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/CrashReporter.java?from=CrashReporter.java#129

replaceAll expects a string
http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#replaceAll%28java.lang.String,%20java.lang.String%29
Attachment #8692504 - Flags: review?(snorp)
(Assignee)

Updated

3 years ago
Assignee: nobody → sledru
Attachment #8692504 - Flags: review?(snorp) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
backed out for bustage on android like https://treeherder.mozilla.org/logviewer.html#?job_id=5997109&repo=fx-team
Flags: needinfo?(sledru)
(Assignee)

Comment 4

3 years ago
Created attachment 8694203 [details] [diff] [review]
regexp.diff

Wrong patch, this should be good.
Attachment #8692504 - Attachment is obsolete: true
Flags: needinfo?(sledru)
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/10f46d149d72
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.