Closed Bug 1228317 Opened 9 years ago Closed 9 years ago

Unintended regular expression in CrashReporter.java

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

Details

(Keywords: coverity, Whiteboard: [CID 119567])

Attachments

(1 file, 1 obsolete file)

regexp.diff
1.41 KB, patch
Details | Diff | Splinter Review
Attached patch regexp.diff (obsolete) — — Splinter Review 
CID 119567 (#1 of 1): Unintended regular expression (REGEX_CONFUSION)regex_expected: The . character(s) in the pattern ".dmp" can match any character, because calls to replaceAll treat the pattern as a regular expression, which might be unexpected.
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/CrashReporter.java?from=CrashReporter.java#129

replaceAll expects a string
http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#replaceAll%28java.lang.String,%20java.lang.String%29
Attachment #8692504 - Flags: review?(snorp)
Assignee: nobody → sledru
Attachment #8692504 - Flags: review?(snorp) → review+
Keywords: checkin-needed
backed out for bustage on android like https://treeherder.mozilla.org/logviewer.html#?job_id=5997109&repo=fx-team
Flags: needinfo?(sledru)
Attached patch regexp.diff — — Splinter Review 
Wrong patch, this should be good.
Attachment #8692504 - Attachment is obsolete: true
Flags: needinfo?(sledru)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/10f46d149d72
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: