Closed
Bug 1228364
Opened 9 years ago
Closed 9 years ago
Implement new IARC constants/mappings
Categories
(Marketplace Graveyard :: API, defect, P1)
Marketplace Graveyard
API
Tracking
(Not tracked)
RESOLVED
FIXED
2015-12-08
People
(Reporter: mat, Assigned: mat)
References
Details
(Whiteboard: [qa-])
The new IARC API has a new set of constants for descriptors and interactives: Their constants used to be human-readable (e.g., "Scary") and we used them as is. Now they slugified them, making IDs (e.g., "PEGI_EL_SCARY"), which means we need to map to a human-readable format.
Kevin plan was:
> This lives in constants/iarc_mappings, constants/rating_descriptors. We should create a new one at constants/iarc_mappings_v2.
> We should simplify and just map each rating body to a language for now (USK is German, CLASSIND is Portuguese, ESRB is English). Many rating bodies display icons anyways. We also map from their IDs to our own slugs which we use to store in our database and reference to our images. Since the ID/string file is so large, we will probably compile it to our codebase with a Python script.
I'm wondering if, we could avoid creating a new mappings file and just add all the new stuff to our existing mappings, and just run migrations to automatically have new fields added to our dynamic models for descriptors/interactives. That's potentially a lot of fields that are irrelevant (that will all be false/null) but the alternative (cloning everything) is not really a great option either.
Assignee | ||
Comment 1•9 years ago
|
||
It looks like rating bodies & ratings haven't changed much, if at all: "AgeRatingText" match our RATINGS mappings, and "RatingAuthorityShortText" match our BODIES (except we need to lowercase it). Regarding descriptors and interactives changes: New classind descriptors: - Naohainadequacoes ("No Descriptor") Removed ESRC descriptors: - 'Crime': 'has_esrb_crime', - 'Criminal Instruction': 'has_esrb_crime_instruct', - 'Hate Speech': 'has_esrb_hate_speech', - 'Scary Themes': 'has_esrb_scary', New ESRB descriptors: - ESRB_DiverseContentDiscretionAdvised - ESRB_NoDescriptors New PEGI descriptors: - PEGI_CriminalTechniqueInstructions - PEGI_ExtremeViolence - PEGI_ImpliedViolence - PEGI_MildSwearing - PEGI_MildViolence - PEGI_ModerateViolence - PEGI_NoDescriptors - PEGI_ParentalGuidanceRecommended - PEGI_SexualInnuendo - PEGI_SexualViolence - PEGI_StrongLanguage - PEGI_StrongViolence - PEGI_UseofAlcoholTobacco Removed PEGI descriptors: # PEGI's versions of Interactive Elements. - 'In-app purchase option': 'has_pegi_digital_purchases', - 'Location data sharing': 'has_pegi_shares_location', - 'Personal data sharing': 'has_pegi_shares_info', - 'Social interaction functionality': 'has_pegi_users_interact', Removed USK descriptors: - 'Drogen': 'has_usk_drugs', Added USK descriptors: - USK_NoDescriptors - USK_ShopStreamingService Rest is the same, except for Generic ratings, which aren't present in the list of new IE/Descriptors text file.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mpillard
Assignee | ||
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
Priority: -- → P1
Assignee | ||
Comment 2•9 years ago
|
||
Fixed in https://github.com/mozilla/zamboni/commit/52dbc89295d70ab8dd9f41e4a65ce19bf03544cf
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Assignee | ||
Updated•9 years ago
|
Target Milestone: --- → 2015-12-08
You need to log in
before you can comment on or make changes to this bug.
Description
•