Closed Bug 1228369 Opened 5 years ago Closed 5 years ago

Rename CodeOffsetLabel => CodeOffset and change its API

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

Details

Attachments

(2 files)

No description provided.
Attached patch 1.renaming.patchSplinter Review
Just the renaming.
Assignee: nobody → benj
Status: NEW → ASSIGNED
Attachment #8692581 - Flags: review?(luke)
use/used => bind/bound
Attachment #8692581 - Flags: review?(luke) → review+
Comment on attachment 8692583 [details] [diff] [review]
2.bindbound.patch

Review of attachment 8692583 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8692583 - Flags: review?(luke) → review+
Fwiw, I've received an email from Talos saying that this provoked a regression:

<Regression> Mozilla-Inbound-Non-PGO - Tp5 No Network Row Major MozAfterPaint (Non-Main Startup File IO Bytes) - WINNT 6.1 (ix) (e10s) - 19.8%

However, this doesn't make sense: the above patches just rename things around, so they shouldn't have any impact on performance.
You need to log in before you can comment on or make changes to this bug.