Closed Bug 1228415 Opened 9 years ago Closed 9 years ago

[TV][Remote Control] Revise l10n string for the disable remote control page

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.5+, b2g-v2.5 fixed, b2g-master verified)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g 2.5+
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed
b2g-master --- verified

People

(Reporter: cynthiatang, Assigned: lchang)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] luke-chang:1228415_tv_remote_control_disabled_string > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
jocheng
: approval-gaia-v2.5+
Details | Review
STR: 1. Launch TV Remote Control 2. Go to Settings 3. Select "Disable remote control" and press OK 4. Press "Save" Actual result: - The string is "You have disabled remote control for connecting through URL, go to Settings to activate this feature." Expected result: - Please refer the document "[TV]2.5 New Strings" - The new string should be "Remote control is disabled, please go to Settings to enable this feature."
QA Whiteboard: [COM=TV::Remote Control]
Flags: needinfo?(lchang)
Assignee: nobody → lchang
Status: NEW → ASSIGNED
Flags: needinfo?(lchang)
Comment on attachment 8692717 [details] [review] [gaia] luke-chang:1228415_tv_remote_control_disabled_string > mozilla-b2g:master Hi Rex, It contains only string and style changes. Please help on this. Thanks.
Attachment #8692717 - Flags: review?(rexboy)
Comment on attachment 8692717 [details] [review] [gaia] luke-chang:1228415_tv_remote_control_disabled_string > mozilla-b2g:master r+ for simple string change.
Attachment #8692717 - Flags: review?(rexboy) → review+
[Blocking Requested - why for this release]: Rex, Thanks. landed on master: https://github.com/mozilla-b2g/gaia/commit/5cec7d8a90c84aba950b991ac8a1c6a4b6b2038f
Status: ASSIGNED → RESOLVED
blocking-b2g: --- → 2.5?
Closed: 9 years ago
status-b2g-v2.5: --- → affected
status-b2g-master: --- → fixed
Resolution: --- → FIXED
Comment on attachment 8692717 [details] [review] [gaia] luke-chang:1228415_tv_remote_control_disabled_string > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): TV Remote Control feature [User impact] if declined: UX Spec violation. [Testing completed]: N/A since only string changed. [Risk to taking this patch] (and alternatives if risky): N/A since only string changed. [String changes made]: Yes, TV team will take care of this.
Attachment #8692717 - Flags: approval-gaia-v2.5?
blocking-b2g: 2.5? → 2.5+
Comment on attachment 8692717 [details] [review] [gaia] luke-chang:1228415_tv_remote_control_disabled_string > mozilla-b2g:master Approve fro TV 2.5 Remote control
Attachment #8692717 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
This issue is verified on v2.6 latest build and the correct string is displayed. [Build Info] gaia: https://github.com/mozilla-b2g/gaia/commit/16f5f723421247daf5e576c210c51f86b31ed77b gecko: https://hg.mozilla.org/mozilla-central/rev/af7c0cb0798f5425d5d344cbaf0ac0ecb1a72a86
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: