1228421 - testApplyArrayInline.js:94:5 Error: Assertion failed: got false, expected true

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/logviewer.html#?job_id=17881107&repo=mozilla-inbound

c:\builds\moz2_slave\m-in_w32_sm-plain-000000000000\src\js\src\jit-test\tests\basic\testApplyArrayInline.js:94:5 Error: Assertion failed: got false, expected true
TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\basic\testApplyArrayInline.js | c:\builds\moz2_slave\m-in_w32_sm-plain-000000000000\src\js\src\jit-test\tests\basic\testApplyArrayInline.js:94:5 Error: Assertion failed: got false, expected true (code 3, args "--ion-eager --ion-offthread-compile=off --non-writable-jitcode --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads")
INFO stderr 2> c:\builds\moz2_slave\m-in_w32_sm-plain-000000000000\src\js\src\jit-test\tests\basic\testApplyArrayInline.js:94:5 Error: Assertion failed: got false, expected true 

TEST-PASS | js\src\jit-test\tests\basic\testApplyArrayInline.js | Success (code 0, args "")
TEST-PASS | js\src\jit-test\tests\basic\testApplyArrayInline.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off")
No bailout: 9
Short: 2
Bailout: 8
c:\builds\moz2_slave\m-in_w32_sm-plain-000000000000\src\js\src\jit-test\tests\basic\testApplyArrayInline.js:94:5 Error: Assertion failed: got false, expected true
Stack:
  @c:\builds\moz2_slave\m-in_w32_sm-plain-000000000000\src\js\src\jit-test\tests\basic\testApplyArrayInline.js:94:5
Exit code: 3
FAIL - basic\testApplyArrayInline.js
TEST-UNEXPECTED-FAIL | js\src\jit-test\tests\basic\testApplyArrayInline.js | c:\builds\moz2_slave\m-in_w32_sm-plain-000000000000\src\js\src\jit-test\tests\basic\testApplyArrayInline.js:94:5 Error: Assertion failed: got false, expected true (code 3, args "--ion-eager --ion-offthread-compile=off --non-writable-jitcode --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads")
INFO exit-status     : 3
INFO timed-out       : False
INFO stdout          > No bailout: 9
INFO stdout          > Short: 2
INFO stdout          > Bailout: 8
INFO stderr         2> c:\builds\moz2_slave\m-in_w32_sm-plain-000000000000\src\js\src\jit-test\tests\basic\testApplyArrayInline.js:94:5 Error: Assertion failed: got false, expected true
INFO stderr         2> Stack:
INFO stderr         2> @c:\builds\moz2_slave\m-in_w32_sm-plain-000000000000\src\js\src\jit-test\tests\basic\testApplyArrayInline.js:94:5
TEST-PASS | js\src\jit-test\tests\basic\testApplyArrayInline.js | Success (code 0, args "--baseline-eager")
TEST-PASS | js\src\jit-test\tests\basic\testApplyArrayInline.js | Success (code 0, args "--baseline-eager --no-fpu")
TEST-PASS | js\src\jit-test\tests\basic\testApplyArrayInline.js | Success (code 0, args "--no-baseline --no-ion")

Comment 1

[Lars T Hansen [:lth]]

Sadly there's a risk of this failing intermittently on hardware under heavy load or virtualized hardware.  I'll probably disable the test (next week).

Comment 2

[Lars T Hansen [:lth]]

Attachment: fix intermittent failure

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8693476 [details] [diff] [review]
fix intermittent failure

Review of attachment 8693476 [details] [diff] [review]:
-----------------------------------------------------------------

Won't prevent this to be landed as it's test only, but I think there's a better way, see comment below :)

::: js/src/jit-test/manual-tests/testApplyArrayInline-perf.js
@@ +74,5 @@
> +if (AinLoop && BinLoop && CinLoop) {
> +    print("No bailout: " + (B - A));
> +    print("Short: " + (C - B));
> +    print("Bailout: " + (D - C));
> +    assertEq((D - C) >= (B - A), true);

Ha, I do understand how this is unsafe, now :)
Generally speaking, when we want to test the performance of important micro-benchmarks (and this could be one, IMO), we just add a very short benchmark to AWFY in the "assorted" directory. I am pretty sure Hannes would agree with this, rather than having an unused test in the test suite.

Comment 4

[Lars T Hansen [:lth]]

bbouvier, excellent point, i'll look into that.

Comment 5

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b14685d14ff56b37f960bc2a4a2cfbc742896053
Bug 1228421 - fix intermittent failure.  r=bbouvier

Comment 6

[Lars T Hansen [:lth]]

Pushed without the perf test; the perf test was filed as a PR on AWFY: https://github.com/h4writer/arewefastyet/pull/88.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b14685d14ff5

Comment 8

[Guilherme Lima]

(In reply to Lars T Hansen [:lth] from comment #6)
> Pushed without the perf test; the perf test was filed as a PR on AWFY:
> https://github.com/h4writer/arewefastyet/pull/88.

Something went wrong? I don't see a graph for this. (and sorry for posting here and not on GitHub, I don't have an account there).

Comment 9

[Lars T Hansen [:lth]]

I agree, the test does not look like it's showing up at present on awfy.

Comment 10

[Hannes Verschore [:h4writer]]

(In reply to Lars T Hansen [:lth] from comment #9)
> I agree, the test does not look like it's showing up at present on awfy.

https://github.com/h4writer/arewefastyet/commit/a2ff9232fff66155f6fb92d601a50bea8903f462

Comment 11

[Hannes Verschore [:h4writer]]

And I can confirm it is now visible on AWFY

Comment 12

[Lars T Hansen [:lth]]

(In reply to Hannes Verschore [:h4writer] from comment #11)
> And I can confirm it is now visible on AWFY

Thank you!