Closed Bug 1228427 Opened 4 years ago Closed 4 years ago

Fix test_serviceworkerinfo.xul

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: catalinb, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

The test asserts registration.active without waiting for the worker to actually become active.

This causes failures on mochitest other:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9424e969d623
Attachment #8692639 - Flags: review?(ehsan)
Comment on attachment 8692639 [details] [diff] [review]
Fix test_serviceworkerinfo.xul: wait for the worker to become active. a=testonly

Review of attachment 8692639 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/test_serviceworkerinfo.xul
@@ +25,5 @@
> +          onChange: function() {
> +            if (registration.activeWorker) {
> +              registration.removeListener(listener);
> +              res(registration);
> +              return;

Nit: no need to return!
Attachment #8692639 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/e921b3682fbf
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.