1228433 - Profile pics are squeezed for smaller resolutions

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task)

Description

[Ioana Chiorean]

Attachment: Screenshot 2015-11-26 22.44.53.png

1) display the page in lower resolutions Ex: 924X 1280

ER:
- profiles pics are rectangular and displayed fine

AR:
- proile pics aresqueezed

Comment 1

[shrvan]

Hello , Is this still a valid bug ? if yes, can you please tell me how to go about resolving it . Its my first time here , some elaborate instruction would be appreciated . Thank-you

Comment 3

[Nikos Roussos [:comzeradd]]

Yes, this is still a valid bug. It affects both events and people pages.

Let me know if you want to work on that.
You can follow the documentation for setting up a local development environment:
http://remo.readthedocs.org/

Comment 4

[Rishi Ahya]

Hi Nikos,

I was hoping me and my team could work on this bug, can you assign it to me?

Comment 5

[Nikos Roussos [:comzeradd]]

That's great Rishi! Let me know if you need any help setting up the development environment.

Comment 6

[Rishi Ahya]

Can you tell me the link/code that we need to be working on

Comment 7

[Rishi Ahya]

Hi Nikos

How do I access the code needed to fix this bug?

Comment 8

[Nikos Roussos [:comzeradd]]

Hey Rishi,

Have you checked the documentation?
http://remo.readthedocs.io/en/latest/installation.html

Depending on what you prefer (docker or virtualenv) you can check the appropriate chapter to setup your local development environment with the reps portal code.

Comment 9

[Rishi Ahya]

we are currently using nostromo in mobaxterm, I have forked the repository and cloned it in our virtual environment. Can you tell me what AR means and ER in comment 1, as we have tried to

Comment 10

[Rishi Ahya]

edit the code, but unsure what we are exactly looking for in terms of resolution, as when we try change the resolution of the screen the images are the same and not squeezed

Comment 11

[Nikos Roussos [:comzeradd]]

ER stands for Expected Result, and AR for Actual Result.

So for instance, if you go the People page and resize it to 768px width you'll see the profile pictures squeezed.

Comment 12

[Rachel]

Hi, I was wondering if the original assignee is still working on this? If not, I'd like to give it a try.

Comment 13

[Rachel]

Since there was no response from previous assignee : 

https://github.com/mozilla/remo/pull/1307

Comment 14

[kevin.kwong.chip]

Hi, as i'm new to the Mozilla code base i'd also like to try and fix this bug as my good first bug if it the issue still open.

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/a284c3a374379d77d43c3c4ff446032c27a87d89
[fix bug 1228433] Profile pics are squeezed for smaller resolutions

https://github.com/mozilla/remo/commit/f73f34e52adbc5f054dca5d0562bf86db52e3023
Merge pull request #1307 from tsmrachel/master

[fix bug 1228433] Profile pics are squeezed for smaller resolutions

Comment 16

[Tasos Katsoulas [:tasos]]

Hi Kevin! Rachel had already submitted a Pull Request for this. If you are still interested in contributing to the ReMo portal, we can find another bug for you to work on. Do you have any preference to back-end (python) or front-end (JS, HTML, CSS) bugs?

Comment 17

[kevin.kwong.chip]

(In reply to Tasos Katsoulas [:tasos] from comment #16)
> Hi Kevin! Rachel had already submitted a Pull Request for this. If you are
> still interested in contributing to the ReMo portal, we can find another bug
> for you to work on. Do you have any preference to back-end (python) or
> front-end (JS, HTML, CSS) bugs?

Yeah sure, i'd prefer front end but as long as I can recreate the environment and bug and have an idea of what should be done to fix it I think I can manage.

Comment 18

[Tasos Katsoulas [:tasos]]

Nikos could you ping Kevin in a mentored bug for the ReMo project?

Comment 19

[Tasos Katsoulas [:tasos]]

Verified on stage that the profile pics are no longer squeezed.

Comment 20

[Nikos Roussos [:comzeradd]]

Hey Kevin,

You can see the mentored list of bugs for the Reps portal. It's not a big list but I plan to add some frontent bugs there.https://bugzilla.mozilla.org/buglist.cgi?f1=bug_mentor&o1=isnotempty&resolution=---&query_format=advanced&component=reps.mozilla.org&product=Mozilla%20Reps&list_id=13462263

Don't hesitate to ping me on IRC if you need any help with setting up your local environment.
http://remo.readthedocs.io/en/latest/