1228438 - Convert event to message is broken (ReferenceError: "aToList is not defined" when calling getRecipientList)

Status: RESOLVED FIXED

Description

[Stefan Sitter [:ssitter]]

Lightning 4.7a1 (20151126030234) with Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0a1

Steps:
Thunderbird is setup with only one "Blogs & News Feeds" account but no email account. When right clicking on an event and selecting Convert To > Message... from context menu nothing happens. The error console shows:

> Error: ReferenceError: aToList is not defined
> Source File: resource://calendar/modules/calUtils.jsm Line: 367

It looks like the broken code was added with Bug 1158036, therefore this problem might exist in Lightning 4.2 and newer. I only tested Lightning 4.6a2 and Lightning 4.7a1.

Comment 1

[[:MakeMyDay]]

Attachment: FixGetRecipientList-V1.diff

Apart from the obvious fix, I add two unit tests for the used calUtils.jsm functions. The patch should be applied on top of that for bug 1212075.

A try push for tests of both bugs is still running.

Comment 2

[Philipp Kewisch [:Fallen] [:📆]]

Comment on attachment 8692989 [details] [diff] [review]
FixGetRecipientList-V1.diff

Review of attachment 8692989 [details] [diff] [review]:
-----------------------------------------------------------------

Check for whitespaces and maybe use an arrow function for the filter

Comment 3

[[:MakeMyDay]]

Attachment: FixGetRecipientList-V2.diff

Updated patch according to the above comments.

We need this also for aurora and beta.

Comment 4

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/c73aed47dd731f55989d63db065b45c5cf51ce5e
Bug 1228438 - Convert event to message is broken;r=philipp

Comment 5

[Martin Schröder [:martinschroeder]]

Keyword "checkin-needed" set for aurora/beta

Comment 6

[Kent James (:rkent)]

Just to be clear, I do not routinely do comm-beta checkins for calendar bugs, but I assume that the calendar team has their own process to get these checked in.

Comment 7

[Philipp Kewisch [:Fallen] [:📆]]

The calendar process has usually been, whoever does the push to c-c also does the backport to approved branches.

Comment 8

[[:MakeMyDay]]

We should either skip the beta uplift for this or also uplift bug 121075.

Comment 9

[Philipp Kewisch [:Fallen] [:📆]]

Backported to releases/comm-aurora changeset 54de083be103

Comment 10

[Philipp Kewisch [:Fallen] [:📆]]

Backported to releases/comm-beta changeset 3866c4feab99

Comment 11

[Stefan Sitter [:ssitter]]

This broke unit tests on beta: https://treeherder.mozilla.org/logviewer.html#?job_id=5710&repo=comm-beta
TEST-UNEXPECTED-FAIL | xpcshell-libical.ini:calendar/test/unit/test_calutils.js | getAttendeeEmail_test - [getAttendeeEmail_test : 59] (test #1) - "[e-mail]" == "\\"Last, First\\" <[e-mail]>"

Comment 12

[[:MakeMyDay]]

yes, this is expected without the uplift at least of bug 1212075, see comment #8.

Comment 13

[Kent James (:rkent)]

Please do not add additional beta test breakages, can we get the issues of comment 11 and comment 8 resolved please?

Comment 14

[[:MakeMyDay]]

The additional backport is already available in the other bug.