Remove unused switches.css file from the system index.html

RESOLVED FIXED

Status

Firefox OS
Gaia::System
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Currently switches.css is being included in the system app in both the FxA module and index.html. We've removed the need for it in index.html after switching to web components, so we can remove it there for the time being.
Created attachment 8692670 [details] [review]
[gaia] KevinGrandon:bug_1228448_remove_unused_switches_css > mozilla-b2g:master
(Assignee)

Comment 2

2 years ago
Comment on attachment 8692670 [details] [review]
[gaia] KevinGrandon:bug_1228448_remove_unused_switches_css > mozilla-b2g:master

Alberto - could you review this simple removal for me? Thanks!
Attachment #8692670 - Flags: review?(apastor)
Comment on attachment 8692670 [details] [review]
[gaia] KevinGrandon:bug_1228448_remove_unused_switches_css > mozilla-b2g:master

LGTM, but could you please also remove [1], now that you are in a line removal mood? Is repeated on [2] :)

Thanks!

[1] https://github.com/KevinGrandon/gaia/blob/bug_1228448_remove_unused_switches_css/apps/system/index.html#L38

[2] https://github.com/KevinGrandon/gaia/blob/bug_1228448_remove_unused_switches_css/apps/system/index.html#L6
Attachment #8692670 - Flags: review?(apastor) → review+
(Assignee)

Comment 4

2 years ago
Silly to have that twice, will fix that as well. Thanks!
(Assignee)

Comment 5

2 years ago
In master: https://github.com/mozilla-b2g/gaia/commit/a0d541d8c5ab93fe655201820ad5fad7558a9cdd
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.