1228456 - MessagePortService leak

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Run with XPCOM_MEM_LEAK_LOG=2
2. Load the testcase
3. Quit

Result: trace-refcnt reports leaks

Comment 1

[Jesse Ruderman]

Attachment: leak log

Comment 2

[Andrea Marchesini [:baku]]

Attachment: leak.patch

Comment 3

[Andrea Marchesini [:baku]]

We must close the MP in case the connecting runnable is not dispatched.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2004e4a39e41

Comment 5

[Daniel Holbert [:dholbert]]

Comment on attachment 8705192 [details] [diff] [review]
leak.patch

>+++ b/dom/workers/WorkerPrivate.cpp
>@@ -1594,16 +1594,23 @@ private:
>   ~MessagePortRunnable()
>+
>+  NS_IMETHOD
>+  Cancel()
>+  {


This was missing an "override" annotation, and causes recent-clang bustage as a result. (the warning in bug 1117034)

baku, mind pushing a followup to fix that?

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3129da8cf850

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2004e4a39e41
https://hg.mozilla.org/mozilla-central/rev/3129da8cf850