Closed Bug 1228456 Opened 4 years ago Closed 4 years ago

MessagePortService leak

Categories

(Core :: DOM: Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 --- affected
firefox46 --- fixed

People

(Reporter: jruderman, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Keywords: memory-leak, testcase)

Attachments

(3 files)

Attached file testcase
1. Run with XPCOM_MEM_LEAK_LOG=2
2. Load the testcase
3. Quit

Result: trace-refcnt reports leaks
Attached file leak log
Attached patch leak.patchSplinter Review
Attachment #8705192 - Flags: review?(bugs)
We must close the MP in case the connecting runnable is not dispatched.
Attachment #8705192 - Flags: review?(bugs) → review+
Comment on attachment 8705192 [details] [diff] [review]
leak.patch

>+++ b/dom/workers/WorkerPrivate.cpp
>@@ -1594,16 +1594,23 @@ private:
>   ~MessagePortRunnable()
>+
>+  NS_IMETHOD
>+  Cancel()
>+  {


This was missing an "override" annotation, and causes recent-clang bustage as a result. (the warning in bug 1117034)

baku, mind pushing a followup to fix that?
Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
https://hg.mozilla.org/mozilla-central/rev/2004e4a39e41
https://hg.mozilla.org/mozilla-central/rev/3129da8cf850
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Assignee: nobody → amarchesini
You need to log in before you can comment on or make changes to this bug.