1228489 - dom/ipc/ContentParent.cpp:5731:12: error: invalid use of incomplete type 'class nsIProfilerStartParams'

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jan Beich]

On platforms lacking SPS profiler (iOS, Linux/PPC, BSDs, Solaris) the build is broken.

In file included from /objdir/dom/ipc/Unified_cpp_dom_ipc0.cpp:38:
dom/ipc/ContentParent.cpp:5731:12: error: member access into
      incomplete type 'nsIProfilerStartParams'
    aParams->GetEntries(&ipcParams.entries());
           ^
../../dist/include/GeckoProfiler.h:68:7: note: forward declaration of
      'nsIProfilerStartParams'
class nsIProfilerStartParams;
      ^
In file included from /objdir/dom/ipc/Unified_cpp_dom_ipc0.cpp:38:
dom/ipc/ContentParent.cpp:5732:12: error: member access into
      incomplete type 'nsIProfilerStartParams'
    aParams->GetInterval(&ipcParams.interval());
           ^
../../dist/include/GeckoProfiler.h:68:7: note: forward declaration of
      'nsIProfilerStartParams'
class nsIProfilerStartParams;
      ^
In file included from /objdir/dom/ipc/Unified_cpp_dom_ipc0.cpp:38:
dom/ipc/ContentParent.cpp:5733:35: error: member access into
      incomplete type 'nsIProfilerStartParams'
    ipcParams.features() = aParams->GetFeatures();
                                  ^
../../dist/include/GeckoProfiler.h:68:7: note: forward declaration of
      'nsIProfilerStartParams'
class nsIProfilerStartParams;
      ^
In file included from /objdir/dom/ipc/Unified_cpp_dom_ipc0.cpp:38:
dom/ipc/ContentParent.cpp:5734:40: error: member access into
      incomplete type 'nsIProfilerStartParams'
    ipcParams.threadFilters() = aParams->GetThreadFilterNames();
                                       ^
../../dist/include/GeckoProfiler.h:68:7: note: forward declaration of
      'nsIProfilerStartParams'
class nsIProfilerStartParams;
      ^
4 errors generated.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: ifdef out ContentParent::StartProfiler for builds without profiler support

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Does the attached patch let you build? If so, I'll try to get it into the tree today.

Comment 3

[Jan Beich]

Yes. My build succeeded with the patch.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a16c2903506aa71c07f0ba3dda932bed03985d0c
Bug 1228489 - ifdef out ContentParent::StartProfiler for builds without profiler support. r=BenWa

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a16c2903506a