Closed Bug 1228491 Opened 4 years ago Closed 4 years ago

[Static Analysis][Uninitialized Members In Class] Class MPEG4Source from MPEG4Extractor.cpp has uninitialized member variables.

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED INVALID
Tracking Status
firefox45 --- affected

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1340246)

Attachments

(1 file)

The Static Analysis tool Coverity added that:
        1. uninit_member: Non-static class member mNextMoofOffset is not initialized in this constructor nor in any functions that it calls.
    	2. uninit_member: Non-static class member mLastParsedTrackId is not initialized in this constructor nor in any functions that it calls.
    	3. uninit_member: Non-static class member mCryptoMode is not initialized in this constructor nor in any functions that it calls.
    	4. uninit_member: Non-static class member mCurrentAuxInfoType is not initialized in this constructor nor in any functions that it calls.
    	5. uninit_member: Non-static class member mCurrentAuxInfoTypeParameter is not initialized in this constructor nor in any functions that it calls.
    	6. uninit_member: Non-static class member mCurrentDefaultSampleInfoSize is not initialized in this constructor nor in any functions that it calls.
    	7. uninit_member: Non-static class member mCurrentSampleInfoCount is not initialized in this constructor nor in any functions that it calls.
    	8. uninit_member: Non-static class member mCurrentSampleInfoOffsetCount is not initialized in this constructor nor in any functions that it calls.
    	9. uninit_member: Non-static class member field mTrackFragmentHeaderInfo.mTrackID is not initialized in this constructor nor in any functions that it calls.
    	10. uninit_member: Non-static class member field mTrackFragmentHeaderInfo.mFlags is not initialized in this constructor nor in any functions that it calls.
    	11. uninit_member: Non-static class member field mTrackFragmentHeaderInfo.mBaseDataOffset is not initialized in this constructor nor in any functions that it calls.
    	12. uninit_member: Non-static class member field mTrackFragmentHeaderInfo.mSampleDescriptionIndex is not initialized in this constructor nor in any functions that it calls.
    	13. uninit_member: Non-static class member field mTrackFragmentHeaderInfo.mDefaultSampleDuration is not initialized in this constructor nor in any functions that it calls.
    	14. uninit_member: Non-static class member field mTrackFragmentHeaderInfo.mDefaultSampleSize is not initialized in this constructor nor in any functions that it calls.
    	15. uninit_member: Non-static class member field mTrackFragmentHeaderInfo.mDefaultSampleFlags is not initialized in this constructor nor in any functions that it calls.
Whiteboard: CID 1340246
Attached patch Bug 1228491.diffSplinter Review
Hello Chris,

Could you please take a look other this patch and tell me what you think, i've only added some class members to be initialized in the constructor.

THX
Attachment #8692803 - Flags: review?(cpearce)
Comment on attachment 8692803 [details] [diff] [review]
Bug 1228491.diff

Review of attachment 8692803 [details] [diff] [review]:
-----------------------------------------------------------------

All these members will soon be removed in bug 1210319, so there's no need to try and fix this issue.
Attachment #8692803 - Flags: review?(cpearce) → review-
OK thanks
Just like bug 1228286, once bug 1210319 has landed, this issue will just disappear.
Depends on: 1210319
But thank you Bogdan for looking into this, much appreciated.
Just please wait until bug 1210319 is fixed (or use its patches locally), before reporting more libstagefright issues.
Sure will do that thanks.
Bug 1210319 has landed, proving that all uninitialized MPEG4Source members were not actually used, so there is no bug here.

Thank you anyway Bodgan for reporting this potential issue.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You're welcome, just trying to help.
You need to log in before you can comment on or make changes to this bug.