1228521 - Fix PDU packing in |ServerSendResponseCmd| for GATT Server API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Comment 1

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1228521 - Fix PDU packing in |ServerSendResponseCmd| for GATT Server API.

* fix passing handle
* add a convert function from GattAuthReq to uint8_t

Comment 2

[Bruce Sun [:brsun]]

Comment on attachment 8692863 [details] [diff] [review]
Bug 1228521 - Fix PDU packing in |ServerSendResponseCmd| for GATT Server API.

Review of attachment 8692863 [details] [diff] [review]:
-----------------------------------------------------------------

Basically it looks to me. But I would suggest not to handle the data member of |BluetoothAttributeHandle| in the command. |PackPDU| and |Convert| are designed to address such details. r=me if |BluetoothAttributeHandle.mHandle| is handled in |Convert| instead of in the command.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1228521 - Fix PDU packing in |ServerSendResponseCmd| for GATT Server API.

* address review comments

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5624d38adf30

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/73d9848a990e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/73d9848a990e