Don't allow media stream cross different type MSG

RESOLVED FIXED in Firefox 45

Status

()

Core
Audio/Video: MediaStreamGraph
P2
normal
Rank:
25
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

unspecified
mozilla45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

In [1], we add the media stream to the "normal" type MSG.

However, we capture the stream from other different type MSG [2] whose type is depending on the |mAudioChannel|.

However, in present design, we don't allow the media stream cross the different MSG. We should keep them consistent.

[1] https://dxr.mozilla.org/mozilla-central/source/dom/html/HTMLMediaElement.cpp#4999 
[2] https://dxr.mozilla.org/mozilla-central/source/dom/html/HTMLMediaElement.cpp#1872
Created attachment 8693461 [details]
MozReview Request: Bug 1228559 - get MSG by audio channel type.

Bug 1228559 - get MSG by audio channel type.
(Assignee)

Updated

2 years ago
Attachment #8693461 - Flags: review?(roc)
Comment on attachment 8693461 [details]
MozReview Request: Bug 1228559 - get MSG by audio channel type.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26475/diff/1-2/
Hi, Roc,
Could you help me review this patch?
You can see more details in comment0.
Very appreciate :)
See Also: → bug 1228484
Rank: 25
Priority: -- → P2
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 10

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7981adc391a8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.