1228625 - Minor calendar sidebar theming issues on OSX 10.11

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Comment 1

[aleth [:aleth]]

Attachment: Today pane button screenshot

The text in the today pane button is readable, but not centered correctly.

Comment 2

[Richard Marti (:Paenglab)]

(In reply to aleth [:aleth] from comment #1)
> Created attachment 8693042 [details]
> Today pane button screenshot
> 
> The text in the today pane button is readable, but not centered correctly.

This is bug 1220455.

Comment 4

[aleth [:aleth]]

Attachment: Top of events sidebar screenshot

The top of the events sidebar looks very busy and isn't quite consistent with its surroundings:

* No top border despite such borders appearing on the left and in the main window. (If it's supposed to be seamless with the tabbar as a design choice, the shade of grey is wrong.)

* Gradient behind the date goes from grey to white, which makes it jump out visually as that styling is used nowhere else (e.g. the toolbar to the left has a much softer gradient)

* Generally the shades of grey used don't seem to match those in the main pane (maybe that's an optical illusion though).

* The horizontal 'line' between the date element and the "New Event" button doesn't quite line up with a similar line in the main pane (that may be unavoidable, or it might be a regression, I don't know.)

Comment 5

[aleth [:aleth]]

Also, the sidebar "shrinks" horizontally when "Tasks" is selected at the top (the other two settings share the same width), which cuts off the buttom at the bottom ("Click here to add new task")

Comment 6

[Richard Marti (:Paenglab)]

Attachment: todayPane.patch

This patch adds for Yosemite+ a top border to the todayPane. On OS X the miny-day borders are now better visible.

The mini-day gradient is on all platforms more similar to their toolbars. Win8 and Win10 have now no gradient to be flat like toolbars.

Comment 7

[aleth [:aleth]]

Attachment: Before and after additional padding.

Looks much better!

A padding-top: 3px, padding-bottom: 1px on .dateValue centers the date number a bit better, and aligns the horizontal line of the bottom border of that part of the panel with the nearby horizontal line in the mail3pane (see screenshot).

Comment 8

[Richard Marti (:Paenglab)]

Attachment: todayPane.patch

The .dateValue should be centered now and on OS X I made the miniDay 1px taller to align the bottom borders. On the other platforms this doesn't work because the bars on mail tab (QFB-bar) and Calendar tab (unifinder-searchBox) don't have the same height.

Comment 9

[Richard Marti (:Paenglab)]

Thank you, Philipp.

Comment 10

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/b0766a5e93463e623770b6333cb2d9a46f496999
Bug 1228625 - Tweak some Today-pane styles. r=Fallen

Comment 11

[aleth [:aleth]]

(In reply to Richard Marti (:Paenglab) from comment #8)
> The .dateValue should be centered now and on OS X I made the miniDay 1px
> taller to align the bottom borders. On the other platforms this doesn't work
> because the bars on mail tab (QFB-bar) and Calendar tab
> (unifinder-searchBox) don't have the same height.

It's the same on OSX actually. The horizontal line now aligns in the calendar tab but not in the mail tab (where there is a 1px mismatch). The easiest fix would be to make the two bars match (it's the calendar tab one that seems to be 1px too small, look at the margins around the searchbox).

Comment 12

[Martin Schröder [:mschroeder]]

Are the issues fully fixed and can the bug be resolved as fixed?