1228636 - Add mach entrypoint for mulet reftests

Status: VERIFIED FIXED

(Testing :: Reftest, defect)

Description

[Andrew Halberstadt [:ahal]]

There is currently no way to run mulet reftests with mach. Support for this should be added.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Yes please

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: MozReview Request: Bug 1228636 - Add mach support for running reftests on mulet, r=jgriffin

Review commit: https://reviewboard.mozilla.org/r/29473/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/29473/

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8703823 [details]
MozReview Request: Bug 1228636 - Add mach support for running reftests on mulet, r=jgriffin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29473/diff/1-2/

Comment 4

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8703823 [details]
MozReview Request: Bug 1228636 - Add mach support for running reftests on mulet, r=jgriffin

https://reviewboard.mozilla.org/r/29473/#review26617

::: layout/tools/reftest/mach_commands.py:97
(Diff revision 2)
> +                test_file = mozpath.relpath(os.path.abspath(test_subdir),

We don't use test_file anywhere...

::: layout/tools/reftest/mach_commands.py:155
(Diff revision 2)
> +            print(MARIONETTE_DISABLED % ('mochitest-b2g-desktop',

Seems like 'mochitest-b2g-desktop' isn't correct here.

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8703823 [details]
MozReview Request: Bug 1228636 - Add mach support for running reftests on mulet, r=jgriffin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29473/diff/2-3/

Comment 6

[Andrew Halberstadt [:ahal]]

https://reviewboard.mozilla.org/r/29473/#review26617

> We don't use test_file anywhere...

Good catch! This was dead code that I copied over.

Comment 7

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8703823 [details]
MozReview Request: Bug 1228636 - Add mach support for running reftests on mulet, r=jgriffin

https://reviewboard.mozilla.org/r/29473/#review26765

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8703823 [details]
MozReview Request: Bug 1228636 - Add mach support for running reftests on mulet, r=jgriffin

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/29473/diff/3-4/

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a4cfd71f9e00

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a4cfd71f9e00

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Thanks!