Closed Bug 1228644 Opened 4 years ago Closed 4 years ago

Created symbols_url is broken on Windows in case an installer is used

Categories

(Release Engineering :: Applications: MozharnessCore, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
Tracking Status
firefox45 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch v1 (obsolete) — Splinter Review
This would fix the bug in a simply manner. The order of installer suffixes is important and code could break if not used correctly. But I wonder if that would ever be the case here.

Otherwise we would have to use a regex for string replacement here which is a bit more extensive.

Try push:
https://hg.mozilla.org/try/pushloghtml?changeset=2fb29fa7d51e
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #8693612 - Flags: review?(jlund)
Comment on attachment 8693612 [details] [diff] [review]
Patch  v1

This seem to have completely broke something. I will have to fix it and will wait for a green try run before asking for review again.
Attachment #8693612 - Flags: review?(jlund)
Attached patch Patch v1.1Splinter Review
Bah! Missing single comma again and no syntax failure by Python. :/

https://treeherder.mozilla.org/#/jobs?repo=try&revision=46b554021e93
Attachment #8693612 - Attachment is obsolete: true
Comment on attachment 8693655 [details] [diff] [review]
Patch v1.1

Looks good now. Formerly busted jobs are passing on Windows. Just let me know if this solution works for you or if a regex should really be used.
Attachment #8693655 - Flags: review?(jlund)
Comment on attachment 8693655 [details] [diff] [review]
Patch v1.1

Review of attachment 8693655 [details] [diff] [review]:
-----------------------------------------------------------------

Jordan doesn't seem to be around those days, and it would be great to have this feature working for our tests given we need mozcrash working due to crashes.
Attachment #8693655 - Flags: review?(jlund) → review?(ahalberstadt)
Comment on attachment 8693655 [details] [diff] [review]
Patch v1.1

Review of attachment 8693655 [details] [diff] [review]:
-----------------------------------------------------------------

Lgtm.
Attachment #8693655 - Flags: review?(ahalberstadt) → review+
https://hg.mozilla.org/mozilla-central/rev/f1012f684bbc
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.