1228656 - Implement utility to group history items by "same site"

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Nick Alexander :nalexander [he/him]]

This tracks implementing some notion of extracting a "site" from a history URL.

The majority of this ticket will be testing the utility.  It's a great time to use a JUnit 4 unit test, like (for example) https://dxr.mozilla.org/mozilla-central/source/mobile/android/tests/background/junit4/src/org/mozilla/gecko/sync/test/TestExtendedJSONObject.java.

Comment 1

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #0)
> This tracks implementing some notion of extracting a "site" from a history
> URL.

I did not expect this, but Firefox for iOS merely groups sites by domain.  This is certainly simple!

But of course it doesn't group twitter.com and m.twitter.com.  I thought the term for this was "eTLD+1", but now I think I may be wrong.  I see a Gecko service that does something like this (https://dxr.mozilla.org/mozilla-central/source/netwerk/dns/nsEffectiveTLDService.cpp) but it's perhaps not what is wanted here.  However, I see a usage that fits exactly what I think we want here: https://dxr.mozilla.org/mozilla-central/source/toolkit/mozapps/downloads/DownloadUtils.jsm#429.  Duplicating this eTLD service into Java just for this sounds like a lot of work for little reward.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Dominique, would you be interested in working on this?

At the simplest level, this would allow us to group history on top sites so instead of seeing the top six results as "facebook.com/someUrl", "facebook.com/someOtherUrl", etc., we could have one tile for Facebook, and the remaining for other "sites", rather than individual urls.

Comment 3

[Dominique Vincent [:domivinc]]

(In reply to Michael Comella (:mcomella) from comment #2)
> Dominique, would you be interested in working on this?
> 
> At the simplest level, this would allow us to group history on top sites so
> instead of seeing the top six results as "facebook.com/someUrl",
> "facebook.com/someOtherUrl", etc., we could have one tile for Facebook, and
> the remaining for other "sites", rather than individual urls.

Sorry again for the delay Michael! I should have enough free time to work on it after December 17th.
So if it's urgent, another person can work on it.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Dominique Vincent [:domivinc] from comment #3)
> Sorry again for the delay Michael! I should have enough free time to work on
> it after December 17th.
> So if it's urgent, another person can work on it.

No worries – take what time you need to. We have "Top sites improvements" in our plans for Q1 so we may prioritize it then but we have no one else to focus on this atm.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.