Closed Bug 1228699 Opened 8 years ago Closed 8 years ago

[zh-TW][mail][suite] mail.addr_book.mapit_url.* changes

Categories

(Mozilla Localizations :: zh-TW / Chinese (Traditional), defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: petercpg, Assigned: petercpg)

Details

(Keywords: productization)

Attachments

(1 file)

Attached patch mapit.patchSplinter Review
This bug contains following changes for both mail and suite:

region.properties:
 - Update map service with Google Map (default), OpenStreetMap
   - Google Map: Use localized name and localized way to note addresses
   - OpenStreetMap: Copy from en-US
Attachment #8693131 - Flags: review?(philipp)
Attachment #8693131 - Flags: review?(bugspam.Callek)
Attachment #8693131 - Flags: review?(philipp) → review+
Flags: needinfo?(bugspam.Callek)
Comment on attachment 8693131 [details] [diff] [review]
mapit.patch

Hi Ian, could you also help review suite part of this patch? thanks.
Attachment #8693131 - Flags: review?(iann_bugzilla)
Comment on attachment 8693131 [details] [diff] [review]
mapit.patch

Most other localisations have the Google Maps arguments in the order:
@A1%20@A2%20@CI%20@ST%20@ZI%20@CO

Assuming it works in the order you have:
@ZI%20@CO%20@ST%20@CI%20@A1%20@A2

then r=me
Flags: needinfo?(bugspam.Callek)
Attachment #8693131 - Flags: review?(iann_bugzilla)
Attachment #8693131 - Flags: review?(bugspam.Callek)
Attachment #8693131 - Flags: review+
Actually the original order is not the order we use in Taiwan. I rechecked on Google Maps that both would work but not on OpenStreetMap so I just have the order tweaked for Google Map.

Patch landed to mail:
Beta: https://hg.mozilla.org/releases/l10n/mozilla-beta/zh-TW/rev/5cd933ba2c94
Aurora: https://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/rev/a7990cb2a952
Central: https://hg.mozilla.org/l10n-central/zh-TW/rev/a7990cb2a952


Patch landed to suite:
Beta: https://hg.mozilla.org/releases/l10n/mozilla-beta/zh-TW/rev/ebc6a128cf3e
Aurora: https://hg.mozilla.org/releases/l10n/mozilla-aurora/zh-TW/rev/75b96c4305d6
Central: https://hg.mozilla.org/l10n-central/zh-TW/rev/75b96c4305d6


Thanks!
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: