Closed Bug 1228708 Opened 4 years ago Closed 4 years ago

"Assertion failure: !Failed(), at ErrorResult.h:103" with undo transaction that throws

Categories

(Core :: DOM: Core & HTML, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: jruderman, Assigned: bzbarsky)

References

Details

(Keywords: assertion, regression, testcase)

Attachments

(3 files)

Attached file testcase
With:
  user_pref("dom.undo_manager.enabled", true);

Assertion failure: !Failed(), at ErrorResult.h:103

This assertion was added recently:

changeset:   https://hg.mozilla.org/mozilla-central/rev/ecb3051bba08
user:        Boris Zbarsky
date:        Fri Nov 20 16:29:41 2015 -0500
summary:     Bug 1224007 part 6.  Change MaybeSetPendingException to set the ErrorResult state to "not failed", just like SuppressException and StealNSResult already do, and assert in the destructor that the ErrorResult is not Failed().
Attached file stack
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8693169 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/b991dcaf5ed9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.