1228721 - vtt.jsm - navigator is not defined

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

JavaScript error: resource://gre/modules/vtt.jsm, line 729: ReferenceError: navigator is not defined

https://hg.mozilla.org/mozilla-central/rev/e715a8fc69e6 pulled in two instances of:

    var isIE8 = (/MSIE\s8\.0/).test(navigator.userAgent);

I guess |navigator| doesn't exist in the context where the code is running.

Comment 1

[Ralph Giles (:rillian)]

Hmm. I guess we can patch this out. Is there a more general way to leave the test but avoid the error? Something like,

var isIE8 = (navigator != undefined) && (/MSIE\s8\.0/).test(navigator.userAgent);

Comment 2

[Jesse Ruderman]

Try this as the first sub-expression:

(typeof navigator !== 'undefined')

Using 'typeof' lets you avoid errors or warnings when it doesn't exist in scope.

Comment 3

[Ralph Giles (:rillian)]

Good point. Jesse, do you feel qualified to review the patch over at https://github.com/mozilla/vtt.js/pull/347 ?

Comment 4

[Jesse Ruderman]

It looks good to me, but I'd feel weird commenting with r+ on a project I didn't know existed until 2 minutes ago.

Comment 5

[Ralph Giles (:rillian)]

Ok, I'll find someone else. Rick isn't around much anymore, and none of the media peers are js experts.

Comment 6

[Jesse Ruderman]

If you're a peer, I suppose you could say I "wrote" the patch and you "reviewed" it.

Comment 7

[Ralph Giles (:rillian)]

Attachment: Apply upstream conditional navigator patch

This is slightly dodgy, using the gecko-navigator branch of https://github.com/rillian/vtt.js. I don't want to use upstream master because of the issues with the code from bug 1167492.

This shouldn't cause any problems updating to the next release once those changes are sorted out, however.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a6f51dd501d

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6a6f51dd501d

Comment 10

[Jesse Ruderman]

Please also fix the other instance in vtt.js.

Comment 11

[Ralph Giles (:rillian)]

Attachment: Apply another upstream conditional navigator patch

Oops. There's another navigator access in BoxPosition().

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/56507104b00b

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/56507104b00b