Closed Bug 1228721 Opened 4 years ago Closed 4 years ago
.jsm - navigator is not defined
Hmm. I guess we can patch this out. Is there a more general way to leave the test but avoid the error? Something like, var isIE8 = (navigator != undefined) && (/MSIE\s8\.0/).test(navigator.userAgent);
Try this as the first sub-expression: (typeof navigator !== 'undefined') Using 'typeof' lets you avoid errors or warnings when it doesn't exist in scope.
Good point. Jesse, do you feel qualified to review the patch over at https://github.com/mozilla/vtt.js/pull/347 ?
Assignee: nobody → giles
It looks good to me, but I'd feel weird commenting with r+ on a project I didn't know existed until 2 minutes ago.
Ok, I'll find someone else. Rick isn't around much anymore, and none of the media peers are js experts.
If you're a peer, I suppose you could say I "wrote" the patch and you "reviewed" it.
This is slightly dodgy, using the gecko-navigator branch of https://github.com/rillian/vtt.js. I don't want to use upstream master because of the issues with the code from bug 1167492. This shouldn't cause any problems updating to the next release once those changes are sorted out, however.
Attachment #8694404 - Flags: review?(kinetik)
Attachment #8694404 - Flags: review?(kinetik) → review+
Please also fix the other instance in vtt.js.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oops. There's another navigator access in BoxPosition().
Attachment #8695351 - Flags: review?(kinetik)
Attachment #8695351 - Flags: review?(kinetik) → review+
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.