Closed
Bug 1228789
Opened 8 years ago
Closed 7 years ago
"ASSERTION: CSSUnprefixingService returned an unrecognized type of gradient function"
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: jruderman, Assigned: dholbert)
References
Details
(Keywords: assertion, testcase)
Attachments
(4 files)
With: user_pref("layout.css.unprefixing-service.globally-whitelisted", true); ###!!! ASSERTION: CSSUnprefixingService returned an unrecognized type of gradient function: 'Error', file layout/style/nsCSSParser.cpp, line 7009
Reporter | ||
Comment 1•8 years ago
|
||
Flags: needinfo?(dholbert)
Assignee | ||
Comment 2•8 years ago
|
||
I've got a local fix for this; I'll post it with a test, when I'm back from lunch. (We could also WONTFIX this like bug 1228796 and bug 1228797, but IMO an assertion-failure seems a bit worse than a JS exception. And the fix is pretty easy; just adding an extra "return false" failure case in the JS.)
Flags: needinfo?(dholbert)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•8 years ago
|
||
Assignee | ||
Comment 4•8 years ago
|
||
Here's the fix. We just need to check the |type| returned by oldGradientParser up-front, and bail if it's unrecognized (or missing). This prevents us from returning things like "undefined-gradient" or "bogus-gradient" as the gradient-type, so that we can live up to the following documentation about the gradient-type outparam from this function (in nsICSSUnprefixingService.idl):
> 54 * @param aUnprefixedFuncName[out]
> 55 * The resulting unprefixed gradient function name:
> 56 * either "linear-gradient" or "radial-gradient".
Attachment #8694956 -
Flags: review?(hsteen)
Updated•8 years ago
|
Attachment #8694956 -
Flags: review?(hsteen) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Not sure why I never landed this, but CSSUnprefixingService is now removed in bug 1259348. Resolving as FIXED by that removal.
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/df20322db27b add this bug's testcase as a crashtest. (no review, test-only)
Assignee | ||
Comment 7•7 years ago
|
||
Try run to be sure the new crashtest doesn't assert: https://treeherder.mozilla.org/#/jobs?repo=try&revision=09d1527b417c40bec3cc6effdc92284c785a8dc0
Assignee | ||
Updated•7 years ago
|
Flags: in-testsuite+
Updated•7 years ago
|
status-firefox45:
affected → ---
status-firefox54:
--- → fixed
status-firefox-esr52:
--- → wontfix
Target Milestone: --- → mozilla54
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/df20322db27b
You need to log in
before you can comment on or make changes to this bug.
Description
•