Closed Bug 1228839 Opened 9 years ago Closed 6 years ago

[l10n] - String not displayed correctly in the Marketplace pages

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: gialloporpora, Unassigned)

Details

(Whiteboard: [marketplace-transition][possible_future_need])

In the italian version of the Marketplace, the word “Componenti aggiuntivi” (Add-ons) in this page is cutted off (at the bottom of the image) http://i.imgur.com/UtYW2Pp.png Is it possible to fix the page layout to display it without shortening the string? I know that we have a very long string for Add-ons, but perhaps this issue affects other languages too.
We could shrink the icon? We could overlay the text on the icon?
Severity: normal → minor
Flags: needinfo?(dspasovski)
Priority: -- → P2
Shrinking the icons and/or overlaying the text on top is possible but it would affect all variations and not just the ones that overflow. In my local testing "Componenti" is cleanly separated from the second line and might be a suitable short-form for add-ons. If we see this happening elsewhere though a more comprehensive fix would be needed.
Flags: needinfo?(dspasovski)
So how to proceed on this?
Flags: needinfo?(ddurst)
Davor's second suggestion sounds good to me, but I can't speak for native speakers.
Flags: needinfo?(ddurst)
Flags: needinfo?(pmo)
Sorry for the late reply. I was on PTO... Here is a list of how this term is translated in various languages. Italian and French are among the longest.
Flags: needinfo?(pmo)
Again how can we proceed on this?
Peiying -- did you mean to attach a list?
Flags: needinfo?(pmo)
(In reply to Trishul from comment #6) > Again how can we proceed on this? Honestly, Trishul, I feel like the right solution for this is different localizations where that string is too long. Peiying, I don't know how we get that to happen, but... this seems like not something we could or should fix with code.
Flags: needinfo?(pmo)
David, if there is a character limitation, it should be put in the note to indicate the maximum length. A lot of times the localizers translate to the full meaning or what sounds natural, not knowing where it shows up or what the layout looks like. As a good practice, if we know the text can't be wrapped to the next line, or there is no scroll bar for a string, then put the restriction in note to let people know in advance. What is the maximum length for this string?
Flags: needinfo?(pmo)
Hmm, good question. My guess is 10-12, but Davor's local testing is probably more accurate.
Flags: needinfo?(dspasovski)
It seems to be about 12 if we allow for a small amount of extra space (non-fixed width font).
Flags: needinfo?(dspasovski)
This should be fixed via localization.
Assignee: nobody → atsay
Whiteboard: [good_first_bug]
Peiying: where would that note go?
Assignee: atsay → administration
Flags: needinfo?(pmo)
Whiteboard: [good_first_bug]
Ideally in developer's note for a particular string. https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_notes. I was hoping to find an example, but it requires me to fish for it in a big repository. For this instance, localizers just have to find another expression or shorten it. But without knowing where it shows up, they just translated the string to reflect the meaning in English. One challenge is that I know for sure not all the communities test their work. With the product constantly being updated, the thorough testing doesn't happen often. As a result, issues are identified much later and only if a community happens to QA it. Of course in order to fix the bug, one has to locate the string in the repository. How do we proceed with this? Obviously several communities need to fix it. Is there a quick way to calculate the length? I can send an email to the locales impacted. Right now I am just eyeballing the Latin character based languages. Some non-latin based languages have issues too.
Flags: needinfo?(pmo)
Well, I don't really know what they'd use -- I assume it would be Pontoon (where it's easy to identify Marketplace Fireplace), and it's sourced from #: /templates/nav.html:14 #: /templates/nav.html:57 #: /templates/addon/list.html:5 Which is visible in both Pontoon and messages.po itself. But if neither of those are how they're accessing it, then I'm not sure what to tell you. This is probably my ignorance about how localizers actually work. :\
If there's a 12(ish) character limit, is this something we can just have localizers solve?
Flags: needinfo?(pmo)
I will ask the few locales that have an issue to fix it.
Flags: needinfo?(pmo)
David, is Fireplace the only one we are maintaining until "end of life" terms is up? Is it used elsewhere?
Flags: needinfo?(ddurst)
The fix is not limited to the three strings, but instances where the feature is references: https://github.com/mozilla/fireplace/search?utf8=%E2%9C%93&q=msgid+%22Add-ons%22. From this query, it looks like we have the potential of 99 entries.
The word "Add-ons" itself is not the issue. Wherever "Add-ons" is part of a larger string, it's probably fine. Those three places (#: /templates/nav.html:14 /templates/nav.html:57 /templates/addon/list.html:5) are the ones where "Add-ons" is by itself. And that's the string that's used by the nav, and the nav is the only place that is an issue. It is 99 results, however. [The search for 'msgid "Add-ons"' in github doesn't search for that complete string, it searches for all pieces of it. It's still 99 results, but they're all that one line in each .po file, per language.]
Flags: needinfo?(ddurst)
Still ok to have locales fix it (if it's an issue)?
Flags: needinfo?(pmo)
Flags: needinfo?(pmo)
Whiteboard: [marketplace-transition][possible_future_need]
Firefox Marketplace has been shut down since March. Closing remaining bugs.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.