Closed Bug 1228885 Opened 4 years ago Closed 4 years ago

Hit MOZ_CRASH(todo) — WebGLTexture::MemoryUsage

Categories

(Core :: Canvas: WebGL, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox45 + fixed
firefox46 --- fixed

People

(Reporter: jruderman, Assigned: jgilbert)

References

Details

(Keywords: crash, regression, testcase, Whiteboard: [gfx-noted])

Crash Data

Attachments

(2 files)

Looks like https://hg.mozilla.org/mozilla-central/rev/7d1c223f397c#l58.175 left WebGLTexture::MemoryUsage incomplete.

Hit MOZ_CRASH(todo) at dom/canvas/WebGLTexture.cpp:168

> #01: mozilla::WebGLMemoryTracker::CollectReports(nsIMemoryReporterCallback*, nsISupports*, bool) [dom/canvas/WebGLMemoryTracker.cpp:32]
> #02: nsRunnableFunction<nsMemoryReporterManager::DispatchReporter(nsIMemoryReporter*, bool, nsIMemoryReporterCallback*, nsISupports*, bool)::$_0>::Run() [xpcom/base/nsMemoryReporterManager.cpp:1679]
> #03: nsThread::ProcessNextEvent(bool, bool*) [xpcom/glue/nsCOMPtr.h:403]
> #04: NS_ProcessPendingEvents(nsIThread*, unsigned int) [xpcom/glue/nsThreadUtils.cpp:239]
> #05: nsBaseAppShell::NativeEventCallback() [widget/nsBaseAppShell.cpp:98]
> #06: nsAppShell::ProcessGeckoEvents(void*) [widget/cocoa/nsAppShell.mm:388]
> #07: CoreFoundation + 0xaa8b1
> #08: CoreFoundation + 0x8a0ac
> #09: CoreFoundation + 0x895cf
> #10: CoreFoundation + 0x88fc8
> #11: HIToolbox + 0x30d55
> #12: HIToolbox + 0x30b8f
> #13: HIToolbox + 0x309cf
> #14: AppKit + 0x49d96
> #15: AppKit + 0x491c5
> #16: -[GeckoNSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] [widget/cocoa/nsAppShell.mm:121]
> #17: AppKit + 0x3dd28
> #18: nsAppShell::Run() [xpcom/glue/nsCOMPtr.h:536]
> #19: nsAppStartup::Run() [toolkit/components/startup/nsAppStartup.cpp:281]
> #20: XREMain::XRE_mainRun() [toolkit/xre/nsAppRunner.cpp:4290]
> #21: XREMain::XRE_main(int, char**, nsXREAppData const*) [toolkit/xre/nsAppRunner.cpp:4383]
> #22: XRE_main [toolkit/xre/nsAppRunner.cpp:4485]
> #23: main [browser/app/nsBrowserApp.cpp:212]

bp-3c8297db-2695-4676-be48-d23312151129
Assignee: nobody → jgilbert
Whiteboard: [gfx-noted]
I can't believe I forgot to do this.

Also evidently this code has zero test coverage?
Attachment #8693836 - Flags: review?(dglastonbury)
Attachment #8693836 - Flags: review?(dglastonbury) → review+
https://hg.mozilla.org/mozilla-central/rev/b575a3ec2d84
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment on attachment 8693836 [details] [diff] [review]
0001-Implemente-WebGLTexture-MemoryUsage.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1221822
[User impact if declined]: Crash when using about:memory after having a WebGL context created.
[Describe test coverage new/current, TreeHerder]: Requires manual testing, but simple to diagnose and test.
[Risks and why]: No risk of it getting worse.
[String/UUID change made/needed]: none
Attachment #8693836 - Flags: approval-mozilla-aurora?
No longer blocks: webgl-tex-refactor
Depends on: webgl-tex-refactor
[Tracking Requested - why for this release]: Crash in about:memory.
Comment on attachment 8693836 [details] [diff] [review]
0001-Implemente-WebGLTexture-MemoryUsage.patch

Fix a crash, taking it.
Attachment #8693836 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.