Closed Bug 1228905 Opened 4 years ago Closed 4 years ago

Include Vendor/Device in content process DXGI adapter searches

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file)

In bug 1225283 we changed the content process device creation code to search for a matching DXGI adapter based on LUIDs. I only tested this on Windows 10. It appears that on Windows Vista and 7, Optimus drivers will use a single LUID for both adapters, which makes it impossible to correctly negotiate the adapter on those systems.

The VendorId/DeviceId fields seem okay though, so we can just include them in the check.

For posterity, I ran some Telemetry numbers to get an upper bound estimate of how many users this affects: that would be the number of sessions running Windows Vista or 7, who have D3D11 availability according to gfxWindowsPlatform, and have two adapters, one Intel and one NVIDIA. This came out to 2% of all sessions, which is thankfully not that high.
Attached patch fixSplinter Review
Attachment #8693415 - Flags: review?(jmuizelaar)
Attachment #8693415 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/4b98f3a5667b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.