Closed Bug 1228921 Opened 4 years ago Closed 4 years ago

write nsChangeHint constants using left shifts

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(2 files)

This means I don't have to carefully count (or copy and paste) 0s when
adding new constants.
Attachment #8693436 - Flags: review?(quanxunzhen)
Comment on attachment 8693436 [details] [diff] [review]
Write nsChangeHint constants using left shifts

Review of attachment 8693436 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Two nits:
1. I don't think the parentheses are necessary here. It's probably better remove them.
2. It seems to me in general we add whitespaces around binary operators, although I cannot find this in our coding style guidelines. (FWIW Google has it [1])


[1] https://google.github.io/styleguide/cppguide.html#Horizontal_Whitespace
Attachment #8693436 - Flags: review?(quanxunzhen) → review+
Yeah, I think you're right about the style.

I'll post a second patch to fix the style for existing constants later in the file.
Attachment #8693803 - Flags: review?(quanxunzhen) → review+
https://hg.mozilla.org/mozilla-central/rev/baff26beaa86
https://hg.mozilla.org/mozilla-central/rev/e2e4a5407b8f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.