1228921 - write nsChangeHint constants using left shifts

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

followup to bug 1224251

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: Write nsChangeHint constants using left shifts

This means I don't have to carefully count (or copy and paste) 0s when
adding new constants.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8693436 [details] [diff] [review]
Write nsChangeHint constants using left shifts

Review of attachment 8693436 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Two nits:
1. I don't think the parentheses are necessary here. It's probably better remove them.
2. It seems to me in general we add whitespaces around binary operators, although I cannot find this in our coding style guidelines. (FWIW Google has it [1])


[1] https://google.github.io/styleguide/cppguide.html#Horizontal_Whitespace

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, I think you're right about the style.

I'll post a second patch to fix the style for existing constants later in the file.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 2 - Fix nsRestyleHint constants to match the same style

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/baff26beaa869743019dba6fb7e179b9eaba8952
Bug 1228921 - Write nsChangeHint constants using left shifts.  r=xidorn

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2e4a5407b8facaf4d05f9ab43ef2d91d119f546
Bug 1228921 patch 2 - Fix nsRestyleHint constants to match the same style.  r=xidorn

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/baff26beaa86
https://hg.mozilla.org/mozilla-central/rev/e2e4a5407b8f