1228929 - [TV] Seperate the Send-to-TV offline content from the iframe

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect, P2)

Description

[Fischer [:Fischer]]

In the simulator, the document.registerElement method is not available inside iframe so smart-button's function will not work.
We have to separate the offline content from the iframe to let smart-button work as expected.

p.s For the online content, we also have to watch this issue. The bug 1228927 is for tracking this issue for the online content.

Comment 1

[Fischer [:Fischer]]

[Blocking Requested - why for this release]:

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1228929-separate-offline-content-from-iframe > mozilla-b2g:master

Comment 3

[Fischer [:Fischer]]

Attachment: PR #33437

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8693451 [details] [review]
PR #33437

r=me with some comments. Please make corresponding change before landing.

Comment 5

[Fischer [:Fischer]]

Land to Master: https://github.com/Fischer-L/gaia/commit/bd5d06143eff25ae84fc586b4e74a8c472d4de6b
Test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=bd5d06143eff25ae84fc586b4e74a8c472d4de6b

Comment 6

[Fischer [:Fischer]]

Comment on attachment 8693450 [details] [review]
[gaia] Fischer-L:bug_1228929-separate-offline-content-from-iframe > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1228929
[User impact] if declined: Button won't react to user's key input
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: Yes

Comment 7

[Fischer [:Fischer]]

@Josh,
This patch should be uplifted to the 2.5 as well, thank you.

Comment 8

[Josh Cheng [:josh]]

Comment on attachment 8693450 [details] [review]
[gaia] Fischer-L:bug_1228929-separate-offline-content-from-iframe > mozilla-b2g:master

Approve for TV 2.5

Comment 9

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/2d54c29f429bed790b5d8284633812dc2b782518