1228949 - Pass WebGL2 buffer-copying-restrictions and buffer-type-restrictions

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

There are some tests failed.
Copying data from a COPY_READ_BUFFER buffer to another target
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.ARRAY_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.COPY_READ_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.COPY_WRITE_BUFFER buffer should work.
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.ELEMENT_ARRAY_BUFFER buffer should fail.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.ELEMENT_ARRAY_BUFFER buffer should work if all buffers were initially bound to ELEMENT_ARRAY_BUFFER.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.PIXEL_PACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.PIXEL_UNPACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.TRANSFORM_FEEDBACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.UNIFORM_BUFFER buffer should work.

Copying data from a COPY_WRITE_BUFFER buffer to another target
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.ARRAY_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.COPY_READ_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.COPY_WRITE_BUFFER buffer should work.
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.ELEMENT_ARRAY_BUFFER buffer should fail.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.ELEMENT_ARRAY_BUFFER buffer should work if all buffers were initially bound to ELEMENT_ARRAY_BUFFER.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.PIXEL_PACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.PIXEL_UNPACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.TRANSFORM_FEEDBACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.UNIFORM_BUFFER buffer should work.

Copying data from a ELEMENT_ARRAY_BUFFER buffer to another target
PASS getError was expected value: INVALID_OPERATION : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.ARRAY_BUFFER buffer should fail.
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.COPY_READ_BUFFER buffer should fail.
PASS getError was expected value: NO_ERROR : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.COPY_READ_BUFFER buffer should work if all buffers were initially bound to ELEMENT_ARRAY_BUFFER.
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.COPY_WRITE_BUFFER buffer should fail.
PASS getError was expected value: NO_ERROR : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.COPY_WRITE_BUFFER buffer should work if all buffers were initially

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Fix content type of WebGLBuffer when the target is LOCAL_GL_COPY_READ_BUFFER or LOCAL_GL_COPY_WRITE_BUFFER

According to the spec[1], binding a buffer with type undefined to the COPY_READ_BUFFER or COPY_WRITE_BUFFER binding points will set its type to other data. 

[1] https://www.khronos.org/registry/webgl/specs/latest/2.0/#5.1

Comment 2

[Ethan Lin[:ethlin]]

Try server result
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8490cade726b

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/241b3b45bf34

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/241b3b45bf34