Closed Bug 1228949 Opened 4 years ago Closed 4 years ago

Pass WebGL2 buffer-copying-restrictions and buffer-type-restrictions

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: ethlin, Assigned: ethlin)

References

()

Details

Attachments

(1 file)

There are some tests failed.
Copying data from a COPY_READ_BUFFER buffer to another target
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.ARRAY_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.COPY_READ_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.COPY_WRITE_BUFFER buffer should work.
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.ELEMENT_ARRAY_BUFFER buffer should fail.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.ELEMENT_ARRAY_BUFFER buffer should work if all buffers were initially bound to ELEMENT_ARRAY_BUFFER.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.PIXEL_PACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.PIXEL_UNPACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.TRANSFORM_FEEDBACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_READ_BUFFER buffer to a gl.UNIFORM_BUFFER buffer should work.

Copying data from a COPY_WRITE_BUFFER buffer to another target
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.ARRAY_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.COPY_READ_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.COPY_WRITE_BUFFER buffer should work.
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.ELEMENT_ARRAY_BUFFER buffer should fail.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.ELEMENT_ARRAY_BUFFER buffer should work if all buffers were initially bound to ELEMENT_ARRAY_BUFFER.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.PIXEL_PACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.PIXEL_UNPACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.TRANSFORM_FEEDBACK_BUFFER buffer should work.
PASS getError was expected value: NO_ERROR : copying from a gl.COPY_WRITE_BUFFER buffer to a gl.UNIFORM_BUFFER buffer should work.

Copying data from a ELEMENT_ARRAY_BUFFER buffer to another target
PASS getError was expected value: INVALID_OPERATION : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.ARRAY_BUFFER buffer should fail.
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.COPY_READ_BUFFER buffer should fail.
PASS getError was expected value: NO_ERROR : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.COPY_READ_BUFFER buffer should work if all buffers were initially bound to ELEMENT_ARRAY_BUFFER.
FAIL getError expected: INVALID_OPERATION. Was NO_ERROR : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.COPY_WRITE_BUFFER buffer should fail.
PASS getError was expected value: NO_ERROR : copying from a gl.ELEMENT_ARRAY_BUFFER buffer to a gl.COPY_WRITE_BUFFER buffer should work if all buffers were initially
According to the spec[1], binding a buffer with type undefined to the COPY_READ_BUFFER or COPY_WRITE_BUFFER binding points will set its type to other data. 

[1] https://www.khronos.org/registry/webgl/specs/latest/2.0/#5.1
Attachment #8693481 - Flags: review?(jgilbert)
Attachment #8693481 - Flags: review?(jgilbert) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/241b3b45bf34
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.