Closed Bug 1228975 Opened 4 years ago Closed 4 years ago

Remove Array generics usage from Places code

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: mak, Assigned: bmanojkumar24, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file, 1 obsolete file)

Attached patch 1228975.patch (obsolete) — Splinter Review
Hi, I want to work on this bug.Please assign the bug to me. I have made the changes, please review them. Thanks.
Attachment #8694034 - Flags: review?(mak77)
Assignee: nobody → bmanojkumar24
Status: NEW → ASSIGNED
Comment on attachment 8694034 [details] [diff] [review]
1228975.patch

Review of attachment 8694034 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Even if it's not code, but just a comment, could you please also change the comment at
http://mxr.mozilla.org/mozilla-central/search?string=Array.concat&find=places
from Array.concat to just concat
So there won't be false positives when someone will do the same cleanup globally for the whole tree

also, please append ".r=mak" to the commit message
Attachment #8694034 - Flags: review?(mak77) → review+
Attached patch 1228975.patchSplinter Review
Hi, I have made appropriate changes.
Attachment #8694034 - Attachment is obsolete: true
Attachment #8694122 - Flags: review?(mak77)
Comment on attachment 8694122 [details] [diff] [review]
1228975.patch

Review of attachment 8694122 [details] [diff] [review]:
-----------------------------------------------------------------

very well, thank you.
Attachment #8694122 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/69ac60b9dec2
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Blocks: 1230471
You need to log in before you can comment on or make changes to this bug.