1228982 - Cannot Upgrade XUL to WebExtension Via Update.Rdf

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[ido.y]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.86 Safari/537.36

Steps to reproduce:

i create an XPI of XUL with the following update.rdf
https://s3.amazonaws.com/s3.walkmedev.com/temp/yana/firefox/walkme_extension_update.rdf

this update will install XPI of XUL on firefox v42 and lower
and will install XPI of WebExtension on firefox v43 - v44

in v43, after i installed the XPI of XUL and run the "Check for updates" i do see a progress bar downloading the new extension
http://screencast.com/t/amayIGV9i
and after restart the browser i see the same version (XUL version)


Actual results:

xul extension is not updated to the new web extension


Expected results:

after updating the extension i should see the Web Extension version instead of the XUL version

links
XUL version
https://s3.amazonaws.com/s3.walkmedev.com/temp/yana/firefox/XUL.xpi
WebExtension version
https://s3.amazonaws.com/s3.walkmedev.com/temp/yana/firefox/WebExtension.xpi
update.rdf
https://s3.amazonaws.com/s3.walkmedev.com/temp/yana/firefox/walkme_extension_update.rdf

Comment 1

[Dave Townsend [:mossop]]

The update.rdf isn't correctly formed. You should put both targetApplication entries alongside each other.

Comment 2

[ido.y]

Hi Dave,

I updated the RDF and I still didn't get the update from XUL to the WebExtension
I'm getting the following error in the browser console
http://screencast.com/t/ys4Kb5bjp

Comment 3

[Dave Townsend [:mossop]]

(In reply to ido.y from comment #2)
> Hi Dave,
> 
> I updated the RDF and I still didn't get the update from XUL to the
> WebExtension
> I'm getting the following error in the browser console
> http://screencast.com/t/ys4Kb5bjp

This error is irrelevant.

Which version of Firefox are you testing with? The current Firefox beta has version 43.0b7 which doesn't match any of the targetApplications in your update.rdf (43.0 > 43.0b7). If you want that to update to the webextension version then you should use something like 43.0a1 as the minVersion there. Note however that custom update URLs aren't supported for web extensions until Firefox 45.

Comment 4

[ido.y]

I'm working on nightly

I changed the min value to be 43.0a1 and max to 45.0
but still - the extension is not updated from XUL to the WebExtensions

The custom update URL was done in the XUL install.rdf

Should it work, right ?
If not, is there another way to update XUL extension for existing users to the webExtensions ?

Comment 5

[Dave Townsend [:mossop]]

Kris, do you want to take a look here? Maybe we broke something with the manifest type detection given that this manifest is delivered as a binary file.

Comment 6

[Kris Maglione [:kmag]]

I don't think it's the type detection. I did add a test for application/octet-stream, but it looks like it only explicitly checks JSON. I think we already had a test for arbitrary content types in RDF updates, though.

In any case, the update.rdf is clearly being parsed properly, but the first item for 1.1.0 is being used. I think it's because strict compatibility is off, so the first entry is considered compatible with all app versions the second is compatible with.

It's worth noting that there's a gap in the compat ranges, so if you turn strict compatibility on, users of, say, 42.0.1, won't be offered any updates.

Comment 7

[ido.y]

I succeed to update XUL to WebExtension when adding the property "<em:strictCompatibility>" to the install.rdf on the XUL extension, is it possible to add this property in the update.rdf?

I fixed the update.rdf versions - thank you :)

Comment 8

[Kris Maglione [:kmag]]

Yes, you can add it to the targetApplication block of the update.rdf file.

Comment 9

[ido.y]

working well,
thank you very much!