1229031 - Don't try to set up pref caches in binding code on worker threads

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Consider this IDL:

  [Exposed=(Window,Worker)]
  interface Foo {
    [Exposed=Window, Pref="whatever"]
    void something();
  };

This is allowed by our IDL parser, because the thing with the Pref annotation is only exposed in Window.  But the code generated for this puts the AddBoolVarCache() call in CreateInterfaceObjects(), which will be called on worker threads too.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Oh, and note that this is hit in practice for Performance.mozMemory.  So if we manage to create a Worker and touch "performance" in it before ever touching "performance" on the main thread, we'll end up adding a pref observer on the worker thread...

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Make sure to not init binding pref var caches on worker threads

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f2c8da919fa1

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f2c8da919fa1