122910 - Chatzilla doesn't work: need third argument for setAttrib()

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Neil Marshall]

In build 2002013103 chatzilla just comes up but doesn't allow me to connect to
anything.

Comment 1

[Alex Vincent [:WeirdAl]]

Error: undefined has no properties
Source File: chrome://chatzilla/content/static.js
Line: 2123

This is apparently fallout from bug 121744, according to bz.

Comment 2

[Alex Vincent [:WeirdAl]]

This is caused in static.js, line 2173.

Comment 3

[Alex Vincent [:WeirdAl]]

Attachment: patch, derived from context of other uses

This patch adds an empty {} as the third argument.  Later uses are similarly
literal Object() objects, exclusively.

Comment 4

[Alex Vincent [:WeirdAl]]

Comment on attachment 67379 [details] [diff] [review]
patch, derived from context of other uses

Patch has caused a different regression.  Now, when I receive a message
addressed to me in #mozillazine, it shows up in both #mozillazine and the
moznet panel.

Comment 5

[Samuel Sieb]

Attachment: skip if 3rd argument is undefined

Comment 6

[Alex Vincent [:WeirdAl]]

Well, in discussion with ssieb in CZ, seems that second regression is a new feature.

ssieb's patch thus has the same logical effect as mine.  The difference is his
patch makes the third argument optional.  Mine, as an alternative, provides an
empty array.

Either one will work.  rginda, I guess this is your call.  :)

Comment 7

[Robert Ginda]

Comment on attachment 67382 [details] [diff] [review]
skip if 3rd argument is undefined

r=rginda

I have to go with making |attrs| optional.

Comment 8

[Samuel Sieb]

checked in