Closed Bug 1229117 Opened 4 years ago Closed 4 years ago

[e10s] dom/html/test/test_bug741266.html fails

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
e10s + ---
firefox45 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This test opens a new window, then immediately checks innerHeight and innerWidth. This fails with e10s, I think because the test is racy. If I add some long setTimeouts after each open, the test passes (though that is obviously not ok to land). Compare to docshell/test/navigation/test_bug344861.html, which uses an onload event before checking innerHeight. Doing that direct conversion here does not work. I think in this case because we pass in "" for the first two arguments, we are loading about:blank, which maybe doesn't generate an onload. It seems like it should be okay to just switch the URI to "/" (because bug 741266 doesn't seem to be specific to about:blank) and then we get an onload.
Change this test to open "/" instead of about:blank so we get an
onload event. Then, wait for the window to be loaded before examining
it.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=72e938ab04bd

I'll attach a diff -w in a minute.
Attachment #8694282 - Flags: review?(bzbarsky)
Attached patch diff -wSplinter Review
Blocks: e10s-tests
tracking-e10s: --- → +
Comment on attachment 8694282 [details] [diff] [review]
Make test_bug741266.html wait for the window to be opened.

I'm not sure what "/" will be and what side-effects loading it might have.  How about:

  var url = URL.createObjectURL(new Blob([""], { type: "text/html" }))

for the url to open?

r=me with that
Attachment #8694282 - Flags: review?(bzbarsky) → review+
Sure. I was just copying test_bug344861.html.
https://hg.mozilla.org/mozilla-central/rev/f71baaaa598d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.