Closed Bug 1229137 Opened 5 years ago Closed 3 years ago

Apple Music embedded video player relies on block-level functions not yet implemented by SpiderMonkey

Categories

(Web Compatibility :: Desktop, defect)

defect
Not set
normal

Tracking

(firefox45 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox45 --- affected

People

(Reporter: till, Unassigned)

References

()

Details

(Whiteboard: [country-all][sitewait])

The linked URL contains an embedded Apple Music video. Clicking on the play button doesn't do anything.

The reason is that the player relies on behavior that some JS engines have but others, including SpiderMonkey don't. ES6 specifies a behavior that should be web-compatible and not break (too much) existing content in Annex B 3.3[1]. Shu is working on changing our implementation to conform with that, and I *think* that should make the player work.

However, even if the change makes the current train, it'll be 3 months until it reaches release. I think it's somewhat likely that Apple Music embeddings will become more common within that time frame.

The thing is that fixing this on the content side is *really* simple: The player's minified code[2] contains "window.onbeforeunload=T;" at the end of line 716. "T" is a function that's defined in line 717, and as this all happens inside an if block, our current behavior of late-binding "T" breaks it. All that's needed to fix the player is to move the function definition above the use.

Perhaps we can contact the responsible team at Apple and have them fix the player so it's not broken for another 3.5 months?


[1] http://www.ecma-international.org/ecma-262/6.0/index.html#sec-block-level-function-declarations-web-legacy-compatibility-semantics
[2] https://embed.itunes.apple.com/htmlResources/B371/web-storefront-musicpreview.js
https://itunes.apple.com/us/post/idsa.76f47263-76c3-11e5-ad28-8822e79f57de is working now in Nightly with Bug 1071646 fixed.

I filed Apple bug 23901076 to ask them to fix for our current users, and tweeted at the one known devrel person: https://twitter.com/miketaylr/status/676797263297953792
Whiteboard: [country-all][sitewait]
(In reply to Mike Taylor [:miketaylr] from comment #1)
> https://itunes.apple.com/us/post/idsa.76f47263-76c3-11e5-ad28-8822e79f57de
> is working now in Nightly with Bug 1071646 fixed.

Unfortunately that change was backed out yesterday and will not ride the next train because a bug in Google Inbox causes that to not work anymore with the change applied. I'm pretty confident it will ride the next train, but that still means it'll be 4.5 months until Apple Music works in release FF.
Apple Devrel filed a Radar bug (23920308) for this https://twitter.com/jonathandavis/status/677158843957121024
That embed is no longer around it seems (in any browser). But 1071646 has landed, so let's close.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Tech Evangelism → Web Compatibility
You need to log in before you can comment on or make changes to this bug.