Summary and event dialog: Persisted dimensions are not applied when opening again

RESOLVED FIXED in 4.7

Status

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

Tracking

Lightning 4.7

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
After resizing of the event summary dialog the dimensions are not persisted accross a dialogs life cycle - at least the persisted information in xulstore.json cannot be applied properly when restoring the dialog.

The behaviour is different from that of the event dialog and is not intended.

If one supresses the setting of a different dialog id (happening on load since bug 491207), persisting works as expected.
Assignee

Comment 1

4 years ago
Also the event dialog is affected, if opened as task dialog. For events, that dialog is not affected, because here only for tasks the dialog id is reset.

An obvious option would be to remove the reset of the dialog id at the cost of loosing the ability to have different dialog icons for tasks and events. But this is probably a price worth to pay.

Another option but a bigger change would be to split both xul files for events and tasks. This would probably bring another win: reducing the number of defined accesskeys for each file to unbreak keyboard navigation in these dialog.

Philipp, do any other options come to your mind?
Flags: needinfo?(philipp)
Summary: Summary dialog: Persisted dimensions are not applied when opening again → Summary and event dialog: Persisted dimensions are not applied when opening again

Comment 2

4 years ago
See also bug 585974 and bug 394195.
Assignee

Comment 3

4 years ago
Referring to Paenglab, only Linux shows such dialog icons at all. So, I'm advocating to remove the dynamic resetting of the dialog id introduced with bug 491207 to resolve the issue.

We can use a unified icon instead maybe the calendar icon.
Tested further. Also Windows is showing the icons when Lightning is installed from AMO.
If you can load the persisted dimensions after changing the dialog id, then you could resize the dialog. Alternatively, is there is some other way to set the icon? If we have to remove the dynamic id setting, we should have an icon that works for both cases.
Flags: needinfo?(philipp)
Assignee

Comment 6

4 years ago
As it seems not to work reliably any way(In reply to Philipp Kewisch [:Fallen] from comment #5)
> If you can load the persisted dimensions after changing the dialog id, then
> you could resize the dialog. Alternatively, is there is some other way to
> set the icon? If we have to remove the dynamic id setting, we should have an
> icon that works for both cases.

Including the icon is some xul magic. So, that would require a fix in xul code. And that's probably not likely to happen anymore.

To modify the size after creating the dialog we would need to open and parse the xulstore.json (additionally) on our own after the the id got updated. Not very nice but possible, I think.
Flags: needinfo?(richard.marti)
Assignee

Updated

4 years ago
Flags: needinfo?(richard.marti) → needinfo?(makemyday)
Assignee

Comment 7

3 years ago
This patch fixes the issue by applying the persisted properties for the modified dialog id after switching ids - so we can leave with the separate icons.
Assignee: nobody → makemyday
Status: NEW → ASSIGNED
Flags: needinfo?(makemyday)
Attachment #8711467 - Flags: review?(philipp)
Attachment #8711467 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8711467 [details] [diff] [review]
FixDialogResizing-V1.diff

Review of attachment 8711467 [details] [diff] [review]:
-----------------------------------------------------------------

Great work, I like it! If this is pushed after the merge then a=me for beta.
Attachment #8711467 - Flags: review?(philipp)
Attachment #8711467 - Flags: review+
Attachment #8711467 - Flags: approval-calendar-aurora?(philipp)
Attachment #8711467 - Flags: approval-calendar-aurora+
Assignee

Comment 9

3 years ago
https://hg.mozilla.org/comm-central/rev/a7f447da91bd
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.8
Assignee

Comment 10

3 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/2fd29471a395
Target Milestone: 4.8 → 4.7
You need to log in before you can comment on or make changes to this bug.