Closed Bug 1229202 Opened 4 years ago Closed 4 years ago

Some cleanups I found while investigating gfxContext-to-DrawTarget conversions

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(7 files)

The first four arguments of GetPageRangeForSelection() are not used usefully,
nor are the first two arguments of FindSelectionBounds() and
FindSelectionBoundsWithList(). (Mutual recursion between the latter two
obscured this fact.)
Attachment #8693829 - Flags: review?(matt.woodrow) → review+
I'm going to repurpose this bug to be more general so I can stick some more small patches here.
Summary: Remove some unused arguments in nsPrintEngine's functions → Some cleanups I found while investigating gfxContext-to-DrawTarget conversions
Attachment #8693965 - Flags: review?(matt.woodrow) → review+
Attachment #8693966 - Flags: review?(matt.woodrow) → review+
Attachment #8693971 - Flags: review?(matt.woodrow) → review+
Attachment #8693972 - Flags: review?(matt.woodrow) → review+
Attachment #8693983 - Flags: review?(matt.woodrow) → review+
Attachment #8694495 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8f81e66d022c8a18e5d47ade0b56374652623e9
Bug 1229202 (part 1) - Remove some unused arguments in nsPrintEngine's functions. r=mattwoodrow.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f78854c2c7233b9dc6692f2b652e9ae36c61b07
Bug 1229202 (part 2) - Remove gfxQuartzSurface::GetCGContextWithClip, which is unused. r=mattwoodrow.

https://hg.mozilla.org/integration/mozilla-inbound/rev/45f90e71e3fbe4d05949e43e6f80db7a5dac7101
Bug 1229202 (part 3) - Make gfxContextAutoDisableSubpixelAntialiasing take a DrawTarget instead of a gfxContext. r=mattwoodrow.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef3fe4b3354887b0228de77ec7b70e4218280e48
Bug 1229202 (part 4) - Remove an unused gfxContextAutoSaveRestore. r=mattwoodrow.

https://hg.mozilla.org/integration/mozilla-inbound/rev/4addc9ac90eaa5162e71867c27d3d3343ab447f6
Bug 1229202 (part 5) - Remove an unneeded gfxContextAutoSaveRestore. r=mattwoodrow.

https://hg.mozilla.org/integration/mozilla-inbound/rev/f07938cebd6f8a0c1bb6b21d6e1986d4dc2e432f
Bug 1229202 (part 6) - Remove two nasty matrix reinterpret_casts. r=mattwoodrow.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3e1abfc084f08983da4c873d41f55429a0c00a2a
Bug 1229202 (part 7) - Pass a DrawTarget to gfxXlibNativeRenderer::DrawDirect(). r=mattwoodrow.
You need to log in before you can comment on or make changes to this bug.