1229226 - Some cleanup around RESOURCE_FILES

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Remove preprocessing support for RESOURCE_FILES

No resource file is preprocessed in gecko, and no resource file is defined
in comm-central.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Reject RESOURCE_FILES along DIST_SUBDIR or XPI_NAME

Gecko only uses resource files in the GRE directory.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8693885 [details] [diff] [review]
Reject RESOURCE_FILES along DIST_SUBDIR or XPI_NAME

Review of attachment 8693885 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +643,5 @@
>          if resources:
> +            if context.get('DIST_SUBDIR') or context.get('XPI_NAME'):
> +                raise SandboxValidationError(
> +                    'RESOURCES_FILES is not allowed along DIST_SUBDIR or '
> +                    'XPI_NAME.', context)

This doesn't read very well to me. How about "RESOURCES_FILES cannot be used with DIST_SUBDIR or XPI_NAME."

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff6fafc6b72a
https://hg.mozilla.org/integration/mozilla-inbound/rev/133d8a4c9e5d

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ff6fafc6b72a
https://hg.mozilla.org/mozilla-central/rev/133d8a4c9e5d