Closed Bug 1229226 Opened 4 years ago Closed 4 years ago

Some cleanup around RESOURCE_FILES

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files)

No description provided.
No resource file is preprocessed in gecko, and no resource file is defined
in comm-central.
Attachment #8693883 - Flags: review?(gps)
Gecko only uses resource files in the GRE directory.
Attachment #8693885 - Flags: review?(gps)
Blocks: 1229233
Blocks: 1229241
Attachment #8693883 - Flags: review?(gps) → review+
Comment on attachment 8693885 [details] [diff] [review]
Reject RESOURCE_FILES along DIST_SUBDIR or XPI_NAME

Review of attachment 8693885 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/frontend/emitter.py
@@ +643,5 @@
>          if resources:
> +            if context.get('DIST_SUBDIR') or context.get('XPI_NAME'):
> +                raise SandboxValidationError(
> +                    'RESOURCES_FILES is not allowed along DIST_SUBDIR or '
> +                    'XPI_NAME.', context)

This doesn't read very well to me. How about "RESOURCES_FILES cannot be used with DIST_SUBDIR or XPI_NAME."
Attachment #8693885 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/ff6fafc6b72a
https://hg.mozilla.org/mozilla-central/rev/133d8a4c9e5d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.