Closed Bug 1229240 Opened 4 years ago Closed 4 years ago

Crash [@ mozilla::dom::MediaStreamTrackBinding::applyConstraints_promiseWrapper]

Categories

(Core :: WebRTC: Audio/Video, defect, P1, critical)

defect

Tracking

()

RESOLVED FIXED
mozilla46
Tracking Status
firefox42 --- unaffected
firefox43 + wontfix
firefox44 + fixed
firefox45 + fixed
firefox46 --- fixed
b2g-v2.5 --- fixed
Blocking Flags:

People

(Reporter: jruderman, Assigned: jib)

References

(Blocks 2 open bugs)

Details

(Keywords: assertion, crash, testcase)

Crash Data

Attachments

(4 files)

Assertion failure: value, at BindingUtils.h:955

bp-e9d7b3be-b6b2-4975-a5c8-58e4e2151201
Attached file stack
May be a MediaStreamTrack issue, but don't know the appropriate component.
Component: Web Audio → Audio/Video: MediaStreamGraph
->jib to look at
Component: Audio/Video: MediaStreamGraph → WebRTC: Audio/Video
Flags: needinfo?(jib)
From debugging: this is the source of the nullptr that leads to the assert:

/home/jesup/src/mozilla/inbound/dom/media/DOMMediaStream.cpp:

already_AddRefed<Promise>
DOMMediaStream::ApplyConstraintsToTrack(TrackID aTrackID,
                                        const MediaTrackConstraints& aConstraints,
                                        ErrorResult &aRv)
{
  return nullptr;
}
Assignee: nobody → jib
Flags: needinfo?(jib)
Bug 1229240 - make applyConstraints() reject instead of crash on non-gUM tracks.
Attachment #8694378 - Flags: review?(rjesup)
[Tracking Requested - why for this release]: crash
Tracked for 44 since it's a crash.
Attachment #8694378 - Flags: review?(rjesup) → review+
Comment on attachment 8694378 [details]
MozReview Request: Bug 1229240 - make applyConstraints() reject instead of crash on non-gUM tracks.

https://reviewboard.mozilla.org/r/26737/#review24331
This is too late to fix in 43 but I'll track it in case it becomes a bigger problem on release.
backlog: --- → webrtc/webaudio+
Rank: 15
Priority: -- → P1
Jan-Ivar, Any reason why this never landed?
Flags: needinfo?(jib)
Comment on attachment 8694378 [details]
MozReview Request: Bug 1229240 - make applyConstraints() reject instead of crash on non-gUM tracks.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/26737/diff/1-2/
(In reply to Sylvestre Ledru [:sylvestre] from comment #10)
> Jan-Ivar, Any reason why this never landed?

Thanks for catching that. Just missing a test, otherwise good to go.
Flags: needinfo?(jib)
Comment on attachment 8703645 [details]
MozReview Request: Bug 1229240 - test that applyConstraints() rejects on non-Gum track.

https://reviewboard.mozilla.org/r/29421/#review26169
Attachment #8703645 - Flags: review?(rjesup) → review+
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/75cb37ee4361
https://hg.mozilla.org/mozilla-central/rev/54d6206da9ee
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Jib, should this be uplifted to Beta44 and Aurora45?
Flags: needinfo?(jib)
Comment on attachment 8694378 [details]
MozReview Request: Bug 1229240 - make applyConstraints() reject instead of crash on non-gUM tracks.

Approval Request Comment
[Feature/regressing bug #]: Bug 912342
[User impact if declined]: Crashable through js.
[Describe test coverage new/current, TreeHerder]: landed on m-c with new test. 
[Risks and why]: very low. Plugs extremely specific edge-case.
[String/UUID change made/needed]: none
Flags: needinfo?(jib)
Attachment #8694378 - Flags: approval-mozilla-beta?
Attachment #8694378 - Flags: approval-mozilla-aurora?
Comment on attachment 8694378 [details]
MozReview Request: Bug 1229240 - make applyConstraints() reject instead of crash on non-gUM tracks.

Fix a crash, taking it.
Attachment #8694378 - Flags: approval-mozilla-beta?
Attachment #8694378 - Flags: approval-mozilla-beta+
Attachment #8694378 - Flags: approval-mozilla-aurora?
Attachment #8694378 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.