Closed Bug 1229263 Opened 7 years ago Closed 7 years ago

move getSupportedNetworkInfo into module

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(tracking-b2g:backlog)

RESOLVED FIXED
tracking-b2g backlog

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(2 files)

getSupportedNetworkInfo function is only used into operator_settings panel, we can remove it from utils.js and the supported_network_type_helper.js
Blocks: 1159657
sound panel also use the getSupportedNetworkInfo, so we'd put them into modules
Summary: move getSupportedNetworkInfo into operator_settings panel → move getSupportedNetworkInfo into module
Assignee: nobody → gasolin
Comment on attachment 8693992 [details] [review]
[gaia] gasolin:issue-1229263 > mozilla-b2g:master

wrap NetworkType and NetworkInfo as AMD module and move them out of util.js

Works fine on device
Attachment #8693992 - Flags: review?(yzenevich)
Comment on attachment 8693992 [details] [review]
[gaia] gasolin:issue-1229263 > mozilla-b2g:master

Scott could you also help review this big patch?
Attachment #8693992 - Flags: review?(scwwu)
Comment on attachment 8693992 [details] [review]
[gaia] gasolin:issue-1229263 > mozilla-b2g:master

Looks good Fred. r+
Attachment #8693992 - Flags: review?(scwwu) → review+
Attachment #8693992 - Flags: review?(yzenevich)
merged https://github.com/mozilla-b2g/gaia/commit/5ae4ebcc7f5a106b0495926bb5ded956ea00f2db

thanks.

We still need to move openlink out of util.js, then we can remove the whole file. Will do so in bug 1159657
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.