1229263 - move getSupportedNetworkInfo into module

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[[e-mail]]

getSupportedNetworkInfo function is only used into operator_settings panel, we can remove it from utils.js and the supported_network_type_helper.js

Comment 1

[[e-mail]]

sound panel also use the getSupportedNetworkInfo, so we'd put them into modules

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1229263 > mozilla-b2g:master

Comment 3

[[e-mail]]

Comment on attachment 8693992 [details] [review]
[gaia] gasolin:issue-1229263 > mozilla-b2g:master

wrap NetworkType and NetworkInfo as AMD module and move them out of util.js

Works fine on device

Comment 4

[[e-mail]]

Comment on attachment 8693992 [details] [review]
[gaia] gasolin:issue-1229263 > mozilla-b2g:master

Scott could you also help review this big patch?

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8693992 [details] [review]
[gaia] gasolin:issue-1229263 > mozilla-b2g:master

Looks good Fred. r+

Comment 6

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/5ae4ebcc7f5a106b0495926bb5ded956ea00f2db

thanks.

We still need to move openlink out of util.js, then we can remove the whole file. Will do so in bug 1159657

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] mozilla-b2g:issue-1229263 > mozilla-b2g:master