1229290 - Uuid of characteristic and descriptor is in the wrong order when adding characteristics and descriptors using GATT server API

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Jocelyn Liu [:jocelyn] [:joliu]]

As same as GATT client API, we should pack and unpack UUIDs of attributes in a reversed order in GATT server API.
Currently only service uuid is pack/unpacked in the right order, this bug is to fix uuids of characteristic and descriptor.

Comment 1

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: Bug 1229290: Pack/unpack UUIDs in a reverse order when adding characteristics and descriptors in GATT server API.

Comment 2

[Bruce Sun [:brsun]]

Comment on attachment 8694037 [details] [diff] [review]
Bug 1229290: Pack/unpack UUIDs in a reverse order when adding characteristics and descriptors in GATT server API.

Review of attachment 8694037 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Thanks for fixing this issue.

Comment 3

[Jocelyn Liu [:jocelyn] [:joliu]]

Attachment: [Final] Bug 1229290: Pack/unpack UUIDs in a reverse order when adding characteristics and descriptors in GATT server API. r=brsun

Thanks for your time, Bruce.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=17460ddb1dc5

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/271d65a7f58e

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/271d65a7f58e