122932 - <wizard/> : classic skin : mailnews wizard displays scroll bar on a wizard page

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[racham]

Wizard shows one of the mailnews account wizard pages with scroll bars (will
post a screenshot) in classic skin mode. We may need to adjust the right margin
of the base wizard.

Comment 1

[racham]

Attachment: screenshot - one of mailnews wizard pages

Comment 2

[Peter Trudelle]

jrgm sez: I create new email accounts on win32 in classic all the time, and I do
not see this scrollbar. Marking WFM. Reopen if jrgm missed something.

Comment 3

[John Morrison]

amazing, and now I see it. Anyways, this isn't really a wizard issue. 
For the given size of the dialog, and the portion that is assigned to 
that deck, there is too much content to show it all without either (a)
scrolling, as the screenshot shows, or (b) clipping, if scrolling is 
disabled. 

-> racham, you need to figure out how that content should fit (or make 
the overall dialog bigger).

Comment 4

[John Morrison]

-> racham

Comment 5

[jglick]

see bug 113488, proposed fix.

Comment 6

[Michael Buckland]

Discussed in 2/27/02 Mail & News bug meeting.  Decisions was to plus this bug.

Comment 7

[racham]

Attachment: screenshot1 - Classic skin : Server Page asking SMTP server name

Comment 8

[racham]

Attachment: screenshot2 - Classic skin : Server Page which has SMTP server name

Comment 9

[racham]

Attachment: screenshot3 - Modern skin : Server Page asking SMTP server name

Comment 10

[racham]

Attachment: screenshot4 - Modern skin : Server Page which has SMTP server name

Comment 11

[racham]

Attachment: screenshot5 - Modern skin : News server page

Comment 12

[racham]

All the above screenshots are taken with the patch that will post next. 

* Couple of things to be noted :

  1. Incoming server label is changed to 'Incoming Server:' from generic 'Server
Name:'
  2. Outgoing server label is changed to 'Outgoing Server:' from generic 'Server
Name:'
  3. News server label is changed to 'News Server:' from generic 'Server Name:'
  4. Group boxes removed around server groups
  5. Outgoing server (when there is one) content is presented briefly
  6. Vertical scroll bars are hence disappeared
  7. Server type, incoming server box and outgoing server boxes are indented and
aligned.
  8. inline styles are removed for server labels

Most of these changes came from Jennifer's screenshot i.e.,
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=71921, except items 2 & 3. 

Jennifer, please make sure that items 2 & 3 are OK with you. thanks.

This bug should knock couple of existing server page bugs out. When I close
this, I will close all the relevant bugs.

Comment 13

[racham]

Attachment: patch, v1.0

Comment 14

[jglick]

Bhuvan, changes look great.

Only one suggestion, "Newsgroup Server:" (label and descriptive text on 
newsgroup dialog) instead of "News Server:" to match rest of terminology in app.

Thanks. :-)

Comment 15

[racham]

Jennifer, thanks.

Modified 'News Server:' to be 'Newsgroup Server:' in my local tree.

Comment 16

[Blake Ross]

Looks good.

Typo in spelling of 'outgoing':

+<!ENTITY haveSmtp1.label "Your existing outgiong server

Comment 17

[racham]

Attachment: Wizard dtd file with changes suggested by Jennifer and Blake

Comment 18

[Sean Su]

Comment on attachment 71956 [details] [diff] [review]
patch, v1.0

r=ssu

Comment 19

[Sean Su]

Comment on attachment 72431 [details] [diff] [review]
Wizard dtd file with changes suggested by Jennifer and Blake 

r=ssu

next time, please attach a patch containing all the changes.

Comment 20

[racham]

Attachment: patch v1.1 - Consolidated patch (of last 2 attachments)

Comment 21

[racham]

Comment on attachment 73110 [details] [diff] [review]
patch v1.1 - Consolidated patch (of last 2 attachments)

c/f r=ssu.

Sean, thanks for the review. 
Blake, can you do a sr= ?
thanks.

Comment 22

[Blake Ross]

Comment on attachment 73110 [details] [diff] [review]
patch v1.1 - Consolidated patch (of last 2 attachments)

sr=blake

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 73110 [details] [diff] [review]
patch v1.1 - Consolidated patch (of last 2 attachments)

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 24

[racham]

fixed (forgot to mark it fixed after my checkin).

Comment 25

[Ninoschka Baca]

Trunk build 2002-03-22: WinMe, Linux RH 7.1, Mac 10.1.3
Verified Fixed