Remove preprocessing from toolbox-window.xul

RESOLVED FIXED in Firefox 45

Status

()

Firefox
Developer Tools: Framework
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 45
Points:
---

Firefox Tracking Flags

(firefox45 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
This prevent toolbox as window to work when using the live-reload addon from bug 1225108.
(Assignee)

Comment 1

2 years ago
Created attachment 8694132 [details] [diff] [review]
patch v1
Attachment #8694132 - Flags: review?(bgrinstead)
Comment on attachment 8694132 [details] [diff] [review]
patch v1

Review of attachment 8694132 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/framework/toolbox-window.xul
@@ +27,5 @@
>           command="toolbox-cmd-close"
>           modifiers="accel"/>
>      <key id="toolbox-key-toggle"
>           key="&toggleToolbox.key;"
> +         command="toolbox-cmd-close"/>

I prefer the way we did it in Bug 1162848 if for nothing else but consistency, but also because you can see the modifiers here next to the key.

So we would have two disabled keys (toolbox-key-toggle and toolbox-key-toggle-osx) then in the js enable the correct one depending on platform, like https://hg.mozilla.org/mozilla-central/rev/2b9780ca7aa8#l2.55.
Attachment #8694132 - Flags: review?(bgrinstead)
(Assignee)

Comment 4

2 years ago
Created attachment 8694224 [details] [diff] [review]
patch v2
Attachment #8694224 - Flags: review?(bgrinstead)
(Assignee)

Updated

2 years ago
Attachment #8694132 - Attachment is obsolete: true
Comment on attachment 8694224 [details] [diff] [review]
patch v2

Review of attachment 8694224 [details] [diff] [review]:
-----------------------------------------------------------------

Need to remove the * in jar.mn to get rid of preprocessing
Attachment #8694224 - Flags: review?(bgrinstead) → review+

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/91642bf07cd0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
You need to log in before you can comment on or make changes to this bug.