Closed
Bug 1229357
Opened 9 years ago
Closed 8 years ago
Don't use -Werror in mingw builds
Categories
(NSS :: Libraries, defect)
Tracking
(firefox45 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox45 | --- | affected |
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
638 bytes,
patch
|
mt
:
review+
|
Details | Diff | Splinter Review |
A patch from bug 1182667 enabled -Werror for mingw unconditionally, which broke the build. In m-c, those -Werror is disabled, but the way it's done for mingw in NSS doesn't allow disabling it. My proposed patch simply removes the flag. I don't think it makes sense to have it in mingw builds - it's not tier 1 platform and having -Werror even if would be fixed now, would probably increase number of build breackages in the future. If you'd rather make it NSS_ENABLE_WERROR aware, I may prepare another patch.
Attachment #8694188 -
Flags: review?(martin.thomson)
|
||
Updated•9 years ago
|
Attachment #8694188 -
Flags: review?(martin.thomson) → review+
|
||
Comment 1•8 years ago
|
||
While I realize this is probably too late for ESR 45, is there something that blocks this from getting checking in?
|
Assignee | |
Comment 2•8 years ago
|
||
This bug wasn't updated, but the patch landed in nss tree and was already merged to m-c. https://hg.mozilla.org/projects/nss/rev/1a2e8b6e713c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•