Closed Bug 1229361 Opened 4 years ago Closed 4 years ago

Support openmax il client amr audio playback

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: ayang, Unassigned)

References

Details

(Whiteboard: [2016-GBT-Y])

Attachments

(2 files)

No description provided.
Priority: -- → P2
Depends on: 1239607
Support AMR narrow band and wide band in platform layer.
Attachment #8713004 - Flags: feedback?(ayang)
Comment on attachment 8713004 [details] [diff] [review]
Support AMR audio

Review of attachment 8713004 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/omx/OmxPlatformLayer.cpp
@@ +123,5 @@
> +    OMX_ERRORTYPE err;
> +
> +    OMX_AUDIO_PARAM_AMRTYPE def;
> +    InitOmxParameter(&def);
> +    def.nPortIndex = 0; // input port

Please iterate the port index instead of hard coding port number in common layer. For example in [1].

[1] https://dxr.mozilla.org/mozilla-central/rev/aa90f482e16db77cdb7dea84564ea1cbd8f7f6b3/dom/media/platforms/omx/OmxDataDecoder.cpp#688
Attachment #8713004 - Flags: feedback?(ayang)
Depends on: 1243681
Attachment #8721214 - Flags: review?(ayang) → review+
Comment on attachment 8721214 [details]
MozReview Request: Bug 1229361 - Support AMR audio in OpenMAX PDM. r?alfredo

https://reviewboard.mozilla.org/r/35605/#review32437
https://hg.mozilla.org/mozilla-central/rev/12e56cb35dc5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.