1229395 - MOZ_NATIVE_JEMALLOC fails to build: memory/build/jemalloc_config.cpp:15:31: fatal error: jemalloc/jemalloc.h: No such file or directory

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Jan Beich]

Building on FreeBSD 11.0C + export MOZ_JEMALLOC4=1 results in

  memory/build/jemalloc_config.cpp:15:10: fatal error:
        'jemalloc/jemalloc.h' file not found
  #include "jemalloc/jemalloc.h"
           ^
  1 error generated.

Comment 1

[Jan Beich]

Attachment: part 1 - Unbreak MOZ_NATIVE_JEMALLOC after bug 1141079

Comment 2

[Jan Beich]

Attachment: part 2 - Rely on MALLOC_H to provide function prototypes for MOZ_NATIVE_JEMALLOC

MOZ_NATIVE_JEMALLOC is FreeBSD-specific for now, anyway.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4bb0f64d9d05

Comment 3

[Jan Beich]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=49d6733d5d40

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ce8227d087d
https://hg.mozilla.org/integration/mozilla-inbound/rev/b72fa463d349

Comment 5

[Jan Beich]

bug 1219914 cancelling bug 762449 and being limited to Nightly makes the patches here NPOTB. Let's request approval just in case.

Comment 6

[Jan Beich]

Comment on attachment 8694626 [details] [diff] [review]
part 1 - Unbreak MOZ_NATIVE_JEMALLOC after bug 1141079

FreeBSD ports being Tier3 downstream enables MOZ_JEMALLOC4 to avoid pessimizations of --disable-jemalloc or crashes with mozjemalloc (see bug 1153683). The approval here is mainly to help updating without stacking even more patches.

Approval Request Comment
[Feature/regressing bug #]: bug 1141079 regression
[User impact if declined]: Broken build on FreeBSD 11 with export MOZ_JEMALLOC4=1 in .mozconfig
[Describe test coverage new/current, TreeHerder]: NPOTB, Try in comment 3, m-i, m-c soon
[Risks and why]: Low. Only affects MOZ_JEMALLOC4 where it can only break build.
[String/UUID change made/needed]: None

NPOTB Try for beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a7ff3f3ed65

Comment 7

[Jan Beich]

Comment on attachment 8694627 [details] [diff] [review]
part 2 - Rely on MALLOC_H to provide function prototypes for MOZ_NATIVE_JEMALLOC

Same as comment 6 mostly for completeness.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3ce8227d087d
https://hg.mozilla.org/mozilla-central/rev/b72fa463d349

Comment 9

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8694626 [details] [diff] [review]
part 1 - Unbreak MOZ_NATIVE_JEMALLOC after bug 1141079

Not part of the build, ok to land on aurora and beta.

Comment 10

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8694627 [details] [diff] [review]
part 2 - Rely on MALLOC_H to provide function prototypes for MOZ_NATIVE_JEMALLOC

Please uplift to aurora and beta, npotb.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/edf64a97e4ea
https://hg.mozilla.org/releases/mozilla-aurora/rev/9e520c4a7512

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f5628a5b5843
https://hg.mozilla.org/releases/mozilla-beta/rev/b0e67a9123ce

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-release/rev/4be77f63b5da
https://hg.mozilla.org/releases/mozilla-release/rev/fbd57ae0485f

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/edf64a97e4ea
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9e520c4a7512