Closed
Bug 1229395
Opened 7 years ago
Closed 7 years ago
MOZ_NATIVE_JEMALLOC fails to build: memory/build/jemalloc_config.cpp:15:31: fatal error: jemalloc/jemalloc.h: No such file or directory
Categories
(Core :: Memory Allocator, defect)
Tracking
()
RESOLVED
FIXED
mozilla45
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
(Whiteboard: [npotb])
Attachments
(2 files)
1.13 KB,
patch
|
glandium
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
2.07 KB,
patch
|
glandium
:
review+
lizzard
:
approval-mozilla-aurora+
lizzard
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Building on FreeBSD 11.0C + export MOZ_JEMALLOC4=1 results in memory/build/jemalloc_config.cpp:15:10: fatal error: 'jemalloc/jemalloc.h' file not found #include "jemalloc/jemalloc.h" ^ 1 error generated.
Attachment #8694626 -
Flags: review?(mh+mozilla)
MOZ_NATIVE_JEMALLOC is FreeBSD-specific for now, anyway. https://treeherder.mozilla.org/#/jobs?repo=try&revision=4bb0f64d9d05
Attachment #8694627 -
Flags: review?(mh+mozilla)
status-firefox43:
--- → affected
status-firefox44:
--- → affected
Updated•7 years ago
|
Attachment #8694626 -
Flags: review?(mh+mozilla) → review+
Updated•7 years ago
|
Attachment #8694627 -
Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ce8227d087d https://hg.mozilla.org/integration/mozilla-inbound/rev/b72fa463d349
Keywords: checkin-needed
bug 1219914 cancelling bug 762449 and being limited to Nightly makes the patches here NPOTB. Let's request approval just in case.
Whiteboard: [npotb]
Comment on attachment 8694626 [details] [diff] [review] part 1 - Unbreak MOZ_NATIVE_JEMALLOC after bug 1141079 FreeBSD ports being Tier3 downstream enables MOZ_JEMALLOC4 to avoid pessimizations of --disable-jemalloc or crashes with mozjemalloc (see bug 1153683). The approval here is mainly to help updating without stacking even more patches. Approval Request Comment [Feature/regressing bug #]: bug 1141079 regression [User impact if declined]: Broken build on FreeBSD 11 with export MOZ_JEMALLOC4=1 in .mozconfig [Describe test coverage new/current, TreeHerder]: NPOTB, Try in comment 3, m-i, m-c soon [Risks and why]: Low. Only affects MOZ_JEMALLOC4 where it can only break build. [String/UUID change made/needed]: None NPOTB Try for beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a7ff3f3ed65
Attachment #8694626 -
Flags: approval-mozilla-beta?
Attachment #8694626 -
Flags: approval-mozilla-aurora?
Comment on attachment 8694627 [details] [diff] [review] part 2 - Rely on MALLOC_H to provide function prototypes for MOZ_NATIVE_JEMALLOC Same as comment 6 mostly for completeness.
Attachment #8694627 -
Flags: approval-mozilla-beta?
Attachment #8694627 -
Flags: approval-mozilla-aurora?
Comment 8•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3ce8227d087d https://hg.mozilla.org/mozilla-central/rev/b72fa463d349
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Comment on attachment 8694626 [details] [diff] [review] part 1 - Unbreak MOZ_NATIVE_JEMALLOC after bug 1141079 Not part of the build, ok to land on aurora and beta.
Attachment #8694626 -
Flags: approval-mozilla-beta?
Attachment #8694626 -
Flags: approval-mozilla-beta+
Attachment #8694626 -
Flags: approval-mozilla-aurora?
Attachment #8694626 -
Flags: approval-mozilla-aurora+
Comment on attachment 8694627 [details] [diff] [review] part 2 - Rely on MALLOC_H to provide function prototypes for MOZ_NATIVE_JEMALLOC Please uplift to aurora and beta, npotb.
Attachment #8694627 -
Flags: approval-mozilla-beta?
Attachment #8694627 -
Flags: approval-mozilla-beta+
Attachment #8694627 -
Flags: approval-mozilla-aurora?
Attachment #8694627 -
Flags: approval-mozilla-aurora+
Keywords: checkin-needed
Whiteboard: [npotb] → [npotb] [checkin-needed-beta] [checkin-needed-aurora]
Comment 11•7 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/edf64a97e4ea https://hg.mozilla.org/releases/mozilla-aurora/rev/9e520c4a7512
Keywords: checkin-needed
Comment 12•7 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/f5628a5b5843 https://hg.mozilla.org/releases/mozilla-beta/rev/b0e67a9123ce
Whiteboard: [npotb] [checkin-needed-beta] [checkin-needed-aurora] → [npotb]
Comment 13•7 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-release/rev/4be77f63b5da https://hg.mozilla.org/releases/mozilla-release/rev/fbd57ae0485f
Comment 14•7 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/edf64a97e4ea https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9e520c4a7512
status-b2g-v2.5:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•