Closed Bug 1229395 Opened 4 years ago Closed 4 years ago

MOZ_NATIVE_JEMALLOC fails to build: memory/build/jemalloc_config.cpp:15:31: fatal error: jemalloc/jemalloc.h: No such file or directory

Categories

(Core :: Memory Allocator, defect)

Unspecified
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox43 --- fixed
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

(Whiteboard: [npotb])

Attachments

(2 files)

Building on FreeBSD 11.0C + export MOZ_JEMALLOC4=1 results in

  memory/build/jemalloc_config.cpp:15:10: fatal error:
        'jemalloc/jemalloc.h' file not found
  #include "jemalloc/jemalloc.h"
           ^
  1 error generated.
Attachment #8694626 - Flags: review?(mh+mozilla)
Attachment #8694626 - Flags: review?(mh+mozilla) → review+
Attachment #8694627 - Flags: review?(mh+mozilla) → review+
bug 1219914 cancelling bug 762449 and being limited to Nightly makes the patches here NPOTB. Let's request approval just in case.
Whiteboard: [npotb]
Comment on attachment 8694626 [details] [diff] [review]
part 1 - Unbreak MOZ_NATIVE_JEMALLOC after bug 1141079

FreeBSD ports being Tier3 downstream enables MOZ_JEMALLOC4 to avoid pessimizations of --disable-jemalloc or crashes with mozjemalloc (see bug 1153683). The approval here is mainly to help updating without stacking even more patches.

Approval Request Comment
[Feature/regressing bug #]: bug 1141079 regression
[User impact if declined]: Broken build on FreeBSD 11 with export MOZ_JEMALLOC4=1 in .mozconfig
[Describe test coverage new/current, TreeHerder]: NPOTB, Try in comment 3, m-i, m-c soon
[Risks and why]: Low. Only affects MOZ_JEMALLOC4 where it can only break build.
[String/UUID change made/needed]: None

NPOTB Try for beta: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a7ff3f3ed65
Attachment #8694626 - Flags: approval-mozilla-beta?
Attachment #8694626 - Flags: approval-mozilla-aurora?
Comment on attachment 8694627 [details] [diff] [review]
part 2 - Rely on MALLOC_H to provide function prototypes for MOZ_NATIVE_JEMALLOC

Same as comment 6 mostly for completeness.
Attachment #8694627 - Flags: approval-mozilla-beta?
Attachment #8694627 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/3ce8227d087d
https://hg.mozilla.org/mozilla-central/rev/b72fa463d349
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Assignee: nobody → jbeich
Comment on attachment 8694626 [details] [diff] [review]
part 1 - Unbreak MOZ_NATIVE_JEMALLOC after bug 1141079

Not part of the build, ok to land on aurora and beta.
Attachment #8694626 - Flags: approval-mozilla-beta?
Attachment #8694626 - Flags: approval-mozilla-beta+
Attachment #8694626 - Flags: approval-mozilla-aurora?
Attachment #8694626 - Flags: approval-mozilla-aurora+
Comment on attachment 8694627 [details] [diff] [review]
part 2 - Rely on MALLOC_H to provide function prototypes for MOZ_NATIVE_JEMALLOC

Please uplift to aurora and beta, npotb.
Attachment #8694627 - Flags: approval-mozilla-beta?
Attachment #8694627 - Flags: approval-mozilla-beta+
Attachment #8694627 - Flags: approval-mozilla-aurora?
Attachment #8694627 - Flags: approval-mozilla-aurora+
Keywords: checkin-needed
Whiteboard: [npotb] → [npotb] [checkin-needed-beta] [checkin-needed-aurora]
You need to log in before you can comment on or make changes to this bug.