Closed Bug 1229433 Opened 9 years ago Closed 9 years ago

Fix mobile eslint failures

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox45 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 45
Tracking Flags:
Tracking Status
firefox45 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

MozReview Request: Bug 1229433 - Ignore HomeProvider in eslint. r=nalexander
40 bytes, text/x-review-board-request
nalexander
: review+
Details 
eslint runs at the top-level now – let's fix the mobile errors so we look good. I only see:

/Users/mcomella/dev/moz/mobile/android/modules/HomeProvider.jsm
  217:11  error  Parsing error: Illegal yield expression

I'm just going to ignore it.
To be unignored and fixed in bug 1178739.
Blocks: 1178739
Comment on attachment 8694298 [details]
MozReview Request: Bug 1229433 - Ignore HomeProvider in eslint. r=nalexander

https://reviewboard.mozilla.org/r/26721/#review24161

Sure.  I'd rather fix it, but whatever.
Attachment #8694298 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/8680e65656f1
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: