browser/fuel/test/browser_Browser.js leaks windows when a marionette session is running

RESOLVED WONTFIX

Status

()

Firefox
General
RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [2016-GBT-Y])

Attachments

(2 attachments)

To satisfy addons signing, the mochitest harness will need to use marionette for bootstrapping (instead of relying on xul overlays). But browser/fuel/test/browser_Browser.js leaks windows when marionette is enabled.

STR:
1. Apply attached patch
2. ./mach mochitest browser/fuel/test/browser_Browser.js

Results:
> 29 INFO TEST-UNEXPECTED-FAIL | browser/fuel/test/browser_Browser.js | leaked until shutdown [nsGlobalWindow #32 inner chrome://mochitests/content/browser/browser/fuel/test/ContentB.html chrome://mochitests/content/browser/browser/fuel/test/ContentB.html] - 
> 30 INFO TEST-UNEXPECTED-FAIL | browser/fuel/test/browser_Browser.js | leaked until shutdown [nsGlobalWindow #27 inner chrome://mochitests/content/browser/browser/fuel/test/ContentWithFrames.html chrome://mochitests/content/browser/browser/fuel/test/ContentWithFrames.html] - 
> 31 INFO TEST-UNEXPECTED-FAIL | browser/fuel/test/browser_Browser.js | leaked until shutdown [nsGlobalWindow #20 outer  chrome://mochitests/content/browser/browser/fuel/test/ContentB.html] - 
> 32 INFO TEST-UNEXPECTED-FAIL | browser/fuel/test/browser_Browser.js | leaked until shutdown [nsGlobalWindow #24 outer  chrome://mochitests/content/browser/browser/fuel/test/ContentWithFrames.html] - 

This is blocking addons signing, so we'll need to either fix or disable this test. Given bug 1090880, maybe disabling this test is easiest?
Created attachment 8694346 [details] [diff] [review]
STR - start a marionette session in mochitest
And here's a log of the failure on try:
https://treeherder.mozilla.org/logviewer.html#?job_id=14115279&repo=try

Marco, given bug 1090880 can this test just be disabled? If not, do you know who could potentially help me look into this?
Flags: needinfo?(mak77)
(In reply to Andrew Halberstadt [:ahal] from comment #2)
> Marco, given bug 1090880 can this test just be disabled? If not, do you know
> who could potentially help me look into this?

Absolutely, you disable the test. FUEL is about to burst into flames.
Flags: needinfo?(mak77)
Created attachment 8695418 [details] [diff] [review]
Disable browser/fuel/test/browser_Browser.js

Thanks! I'll wait to land this alongside bug 1224294 when it's ready.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Attachment #8695418 - Flags: review?(mak77)
Comment on attachment 8695418 [details] [diff] [review]
Disable browser/fuel/test/browser_Browser.js

Review of attachment 8695418 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/fuel/test/browser.ini
@@ +9,5 @@
>  [browser_ApplicationQuitting.js]
>  [browser_ApplicationStorage.js]
>  [browser_Bookmarks.js]
>  [browser_Browser.js]
> +disabled = "Bug 1229465 - Leaks windows when marionette is enabled, which blocks bug 1224294"

I'm not sure if disabled reason requires apices or not, looks like most consumers don't provide them.
http://mxr.mozilla.org/mozilla-central/search?string=disabled+%3D&find=.ini

btw, whatever works on Try will be fine.
Attachment #8695418 - Flags: review?(mak77) → review+
Upon further investigation, I found that lots of the debug (non-fuel) browser-chrome tests also had this problem with my patch. Just for some reason this was the only one that failed on opt. I found a workaround for the underlying issue, and this test no longer fails with my patch. Might as well WONTFIX this and let the test be removed along with the rest of fuel. Sorry for the wasted cycles.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
Whiteboard: [2016-GBT-Y]
You need to log in before you can comment on or make changes to this bug.